gpiolib: Remove redundant assignment of return variable

In some functions the returned variable is assigned to 0 and then
reassigned to the actual value. Remove redundant assignments.

In one case make it more clear that the assignment is not needed.

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Link: https://lore.kernel.org/r/20250416095645.2027695-9-andriy.shevchenko@linux.intel.com
Signed-off-by: Bartosz Golaszewski <brgl@bgdev.pl>

diff --git a/drivers/gpio/gpiolib.c b/drivers/gpio/gpiolib.c
index 3243ef3fc7d8b508ca60ed57c958dea07ba260d1..87903847c3d7f7520138e4ae8ff525dfaba5feb5 100644 (file)
--- a/drivers/gpio/gpiolib.c
+++ b/drivers/gpio/gpiolib.c
@@ -1015,7 +1015,7 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
        struct gpio_device *gdev;
        unsigned int desc_index;
        int base = 0;
-       int ret = 0;
+       int ret;
 
        /* Only allow one set() and one set_multiple(). */
        if ((gc->set && gc->set_rv) ||
@@ -1040,11 +1040,10 @@ int gpiochip_add_data_with_key(struct gpio_chip *gc, void *data,
 
        device_set_node(&gdev->dev, gpiochip_choose_fwnode(gc));
 
-       gdev->id = ida_alloc(&gpio_ida, GFP_KERNEL);
-       if (gdev->id < 0) {
-               ret = gdev->id;
+       ret = ida_alloc(&gpio_ida, GFP_KERNEL);
+       if (ret < 0)
                goto err_free_gdev;
-       }
+       gdev->id = ret;
 
        ret = dev_set_name(&gdev->dev, GPIOCHIP_NAME "%d", gdev->id);
        if (ret)
@@ -3068,7 +3067,7 @@ set_output_flag:
  */
 int gpiod_enable_hw_timestamp_ns(struct gpio_desc *desc, unsigned long flags)
 {
-       int ret = 0;
+       int ret;
 
        VALIDATE_DESC(desc);
 
@@ -3101,7 +3100,7 @@ EXPORT_SYMBOL_GPL(gpiod_enable_hw_timestamp_ns);
  */
 int gpiod_disable_hw_timestamp_ns(struct gpio_desc *desc, unsigned long flags)
 {
-       int ret = 0;
+       int ret;
 
        VALIDATE_DESC(desc);