firmware: arm_scmi: Support vendor protocol modules autoloading

SCMI vendor protocols namespace is shared amongst all vendors so that there
can be multiple implementation for the same protocol ID by different
vendors, exposing completely different functionalities and used by distinct
SCMI vendor drivers.

For these reasons, at runtime, when some driver asks for a protocol, the
proper implementation to use is chosen based on the SCMI vendor/subvendor/
impl_version data as advertised by the platform SCMI server and gathered
from the SCMI core during stack initialization: this enables proper runtime
selection of vendor protocols even when many different protocols from
different vendors are built into the same image via a common defconfig.

This same selection mechanism works similarly well even when all the vendor
protocols are compiled as loadable modules, as long as all such required
protocol modules have been previously loaded by some other means.

Add support for the automatic loading of vendor protocol modules, based on
protocol/vendor IDs, when an SCMI driver attempts to use such a protocol.

Reported-by: Johan Hovold <johan+linaro@kernel.org>
Closes: https://lore.kernel.org/lkml/ZytnRc94iKUfMYH0@hovoldconsulting.com/
Signed-off-by: Cristian Marussi <cristian.marussi@arm.com>
Message-Id: <20241209164957.1801886-2-cristian.marussi@arm.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

diff --git a/drivers/firmware/arm_scmi/driver.c b/drivers/firmware/arm_scmi/driver.c
index eeed1689b208077549fbe617af7e980d720834ea..60050da54bf24c0245290e846f91aea62392855b 100644 (file)
--- a/drivers/firmware/arm_scmi/driver.c
+++ b/drivers/firmware/arm_scmi/driver.c
@@ -24,6 +24,7 @@
 #include <linux/io.h>
 #include <linux/io-64-nonatomic-hi-lo.h>
 #include <linux/kernel.h>
+#include <linux/kmod.h>
 #include <linux/ktime.h>
 #include <linux/hashtable.h>
 #include <linux/list.h>
@@ -43,6 +44,8 @@
 #define CREATE_TRACE_POINTS
 #include <trace/events/scmi.h>
 
+#define SCMI_VENDOR_MODULE_ALIAS_FMT   "scmi-protocol-0x%02x-%s"
+
 static DEFINE_IDA(scmi_id);
 
 static DEFINE_XARRAY(scmi_protocols);
@@ -275,6 +278,44 @@ scmi_vendor_protocol_lookup(int protocol_id, char *vendor_id,
        return proto;
 }
 
+static const struct scmi_protocol *
+scmi_vendor_protocol_get(int protocol_id, struct scmi_revision_info *version)
+{
+       const struct scmi_protocol *proto;
+
+       proto = scmi_vendor_protocol_lookup(protocol_id, version->vendor_id,
+                                           version->sub_vendor_id,
+                                           version->impl_ver);
+       if (!proto) {
+               int ret;
+
+               pr_debug("Looking for '" SCMI_VENDOR_MODULE_ALIAS_FMT "'\n",
+                        protocol_id, version->vendor_id);
+
+               /* Note that vendor_id is mandatory for vendor protocols */
+               ret = request_module(SCMI_VENDOR_MODULE_ALIAS_FMT,
+                                    protocol_id, version->vendor_id);
+               if (ret) {
+                       pr_warn("Problem loading module for protocol 0x%x\n",
+                               protocol_id);
+                       return NULL;
+               }
+
+               /* Lookup again, once modules loaded */
+               proto = scmi_vendor_protocol_lookup(protocol_id,
+                                                   version->vendor_id,
+                                                   version->sub_vendor_id,
+                                                   version->impl_ver);
+       }
+
+       if (proto)
+               pr_info("Loaded SCMI Vendor Protocol 0x%x - %s %s %X\n",
+                       protocol_id, proto->vendor_id ?: "",
+                       proto->sub_vendor_id ?: "", proto->impl_ver);
+
+       return proto;
+}
+
 static const struct scmi_protocol *
 scmi_protocol_get(int protocol_id, struct scmi_revision_info *version)
 {
@@ -283,10 +324,8 @@ scmi_protocol_get(int protocol_id, struct scmi_revision_info *version)
        if (protocol_id < SCMI_PROTOCOL_VENDOR_BASE)
                proto = xa_load(&scmi_protocols, protocol_id);
        else
-               proto = scmi_vendor_protocol_lookup(protocol_id,
-                                                   version->vendor_id,
-                                                   version->sub_vendor_id,
-                                                   version->impl_ver);
+               proto = scmi_vendor_protocol_get(protocol_id, version);
+
        if (!proto || !try_module_get(proto->owner)) {
                pr_warn("SCMI Protocol 0x%x not found!\n", protocol_id);
                return NULL;
@@ -294,11 +333,6 @@ scmi_protocol_get(int protocol_id, struct scmi_revision_info *version)
 
        pr_debug("Found SCMI Protocol 0x%x\n", protocol_id);
 
-       if (protocol_id >= SCMI_PROTOCOL_VENDOR_BASE)
-               pr_info("Loaded SCMI Vendor Protocol 0x%x - %s %s %X\n",
-                       protocol_id, proto->vendor_id ?: "",
-                       proto->sub_vendor_id ?: "", proto->impl_ver);
-
        return proto;
 }
 
@@ -366,7 +400,9 @@ int scmi_protocol_register(const struct scmi_protocol *proto)
                return ret;
        }
 
-       pr_debug("Registered SCMI Protocol 0x%x\n", proto->id);
+       pr_debug("Registered SCMI Protocol 0x%x - %s  %s  0x%08X\n",
+                proto->id, proto->vendor_id, proto->sub_vendor_id,
+                proto->impl_ver);
 
        return 0;
 }