]> www.infradead.org Git - mtd-utils.git/commitdiff
jffs2dump: check return value of lseek
authorDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>
Sat, 2 Sep 2023 14:11:44 +0000 (16:11 +0200)
committerDavid Oberhollenzer <david.oberhollenzer@sigma-star.at>
Sat, 2 Sep 2023 14:11:44 +0000 (16:11 +0200)
On error, lseek returns a negative value. We need to check for that
and abort, instead of passing -1 to malloc and later on to read_nocheck.

Signed-off-by: David Oberhollenzer <david.oberhollenzer@sigma-star.at>
jffsX-utils/jffs2dump.c

index d30b59f69dbcb6f5482e3fe0bfdfff0a27b64720..30455ea479af0d440deb37132bd31c7122bc1a3b 100644 (file)
@@ -757,6 +757,12 @@ int main(int argc, char **argv)
 
        // get image length
        imglen = lseek(fd, 0, SEEK_END);
+       if (imglen < 0) {
+               perror(img);
+               close(fd);
+               exit(EXIT_FAILURE);
+       }
+
        lseek (fd, 0, SEEK_SET);
 
        data = malloc (imglen);