]> www.infradead.org Git - users/dwmw2/qemu.git/commitdiff
qga-win: Enable 'can-offline' field in 'guest-get-vcpus' reply
authorSameeh Jubran <sameeh@daynix.com>
Tue, 11 Apr 2017 12:52:05 +0000 (15:52 +0300)
committerMichael Roth <mdroth@linux.vnet.ibm.com>
Thu, 27 Apr 2017 04:56:47 +0000 (23:56 -0500)
The QGA schema states:

@can-offline: Whether offlining the VCPU is possible. This member
               is always filled in by the guest agent when the structure
               is returned, and always ignored on input (hence it can be
               omitted then).

Currently 'can-offline' is missing entirely from the reply. This causes
errors in libvirt which is expecting the reply to be compliant with the
schema docs.

BZ#1438735: https://bugzilla.redhat.com/show_bug.cgi?id=1438735

Signed-off-by: Sameeh Jubran <sameeh@daynix.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Cc: qemu-stable@nongnu.org
Signed-off-by: Michael Roth <mdroth@linux.vnet.ibm.com>
qga/commands-win32.c

index 04026eedbf2facdfbf75dfdee6cf327531d95e73..9fec1fb6389ca44d0b56f0962761a3f5b86923ce 100644 (file)
@@ -1344,7 +1344,7 @@ GuestLogicalProcessorList *qmp_guest_get_vcpus(Error **errp)
                     vcpu = g_malloc0(sizeof *vcpu);
                     vcpu->logical_id = current++;
                     vcpu->online = true;
-                    vcpu->has_can_offline = false;
+                    vcpu->has_can_offline = true;
 
                     entry = g_malloc0(sizeof *entry);
                     entry->value = vcpu;