suport device driver initialization model
authorGlauber Costa <glommer@redhat.com>
Thu, 23 Apr 2009 19:20:55 +0000 (15:20 -0400)
committerAnthony Liguori <aliguori@us.ibm.com>
Fri, 1 May 2009 15:12:27 +0000 (10:12 -0500)
According to PnP specification, Appendix B, Option ROMs
that support DDIM (device driver initialization model) should
have their memory space writeable.

KVM deviates from us here, by removing the IO_MEM_ROM flag,
to allow for PCI option ROMs (they require DDIM). However,
there's absolutely no reason we can't do the same.

Signed-off-by: Glauber Costa <glommer@redhat.com>
Signed-off-by: Anthony Liguori <aliguori@us.ibm.com>
hw/pc.c

diff --git a/hw/pc.c b/hw/pc.c
index 38493907020b22685886dd6e965da7ffcd6c8227..6e3d03f6c8184003cace9de59939b4d7095d3a49 100644 (file)
--- a/hw/pc.c
+++ b/hw/pc.c
@@ -899,7 +899,7 @@ vga_bios_error:
             load_linux(phys_ram_base + option_rom_offset,
                        kernel_filename, initrd_filename, kernel_cmdline);
             cpu_register_physical_memory(0xd0000, TARGET_PAGE_SIZE,
-                                         option_rom_offset | IO_MEM_ROM);
+                                         option_rom_offset);
             offset = TARGET_PAGE_SIZE;
         }