KVM: arm64: Fix nested S2 MMU structures reallocation

For each vcpu that userspace creates, we allocate a number of
s2_mmu structures that will eventually contain our shadow S2
page tables.

Since this is a dynamically allocated array, we reallocate
the array and initialise the newly allocated elements. Once
everything is correctly initialised, we adjust pointer and size
in the kvm structure, and move on.

But should that initialisation fail *and* the reallocation triggered
a copy to another location, we end-up returning early, with the
kvm structure still containing the (now stale) old pointer. Weeee!

Cure it by assigning the pointer early, and use this to perform
the initialisation. If everything succeeds, we adjust the size.
Otherwise, we just leave the size as it was, no harm done, and the
new memory is as good as the ol' one (we hope...).

Fixes: 4f128f8e1aaac ("KVM: arm64: nv: Support multiple nested Stage-2 mmu structures")
Reported-by: Alexander Potapenko <glider@google.com>
Tested-by: Alexander Potapenko <glider@google.com>
Link: https://lore.kernel.org/r/20250204145554.774427-1-maz@kernel.org
Signed-off-by: Marc Zyngier <maz@kernel.org>

diff --git a/arch/arm64/kvm/nested.c b/arch/arm64/kvm/nested.c
index 33d2ace6866587ef2abfac800f56dd85a84ca9e3..0c9387d2f50708565b5aac1fc0f86fefffd94ea1 100644 (file)
--- a/arch/arm64/kvm/nested.c
+++ b/arch/arm64/kvm/nested.c
@@ -67,26 +67,27 @@ int kvm_vcpu_init_nested(struct kvm_vcpu *vcpu)
        if (!tmp)
                return -ENOMEM;
 
+       swap(kvm->arch.nested_mmus, tmp);
+
        /*
         * If we went through a realocation, adjust the MMU back-pointers in
         * the previously initialised kvm_pgtable structures.
         */
        if (kvm->arch.nested_mmus != tmp)
                for (int i = 0; i < kvm->arch.nested_mmus_size; i++)
-                       tmp[i].pgt->mmu = &tmp[i];
+                       kvm->arch.nested_mmus[i].pgt->mmu = &kvm->arch.nested_mmus[i];
 
        for (int i = kvm->arch.nested_mmus_size; !ret && i < num_mmus; i++)
-               ret = init_nested_s2_mmu(kvm, &tmp[i]);
+               ret = init_nested_s2_mmu(kvm, &kvm->arch.nested_mmus[i]);
 
        if (ret) {
                for (int i = kvm->arch.nested_mmus_size; i < num_mmus; i++)
-                       kvm_free_stage2_pgd(&tmp[i]);
+                       kvm_free_stage2_pgd(&kvm->arch.nested_mmus[i]);
 
                return ret;
        }
 
        kvm->arch.nested_mmus_size = num_mmus;
-       kvm->arch.nested_mmus = tmp;
 
        return 0;
 }