dmapool: rearrange page alloc failure handling

Handle the error in a condition so the good path can be in the normal
flow.

Link: https://lkml.kernel.org/r/20230126215125.4069751-8-kbusch@meta.com
Fixes: 2d55c16c0c54 ("dmapool: create/destroy cleanup")
Signed-off-by: Keith Busch <kbusch@kernel.org>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Cc: Matthew Wilcox <willy@infradead.org>
Cc: Tony Battersby <tonyb@cybernetics.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>

diff --git a/mm/dmapool.c b/mm/dmapool.c
index 30b069e999968c4d6c4e62ff9d08d4fdfc2a0fb1..900f2afa363a9b8916d53dcadb694c998c81ea1e 100644 (file)
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -292,17 +292,19 @@ static struct dma_page *pool_alloc_page(struct dma_pool *pool, gfp_t mem_flags)
        page = kmalloc(sizeof(*page), mem_flags);
        if (!page)
                return NULL;
+
        page->vaddr = dma_alloc_coherent(pool->dev, pool->allocation,
                                         &page->dma, mem_flags);
-       if (page->vaddr) {
-               pool_init_page(pool, page);
-               pool_initialise_page(pool, page);
-               page->in_use = 0;
-               page->offset = 0;
-       } else {
+       if (!page->vaddr) {
                kfree(page);
-               page = NULL;
+               return NULL;
        }
+
+       pool_init_page(pool, page);
+       pool_initialise_page(pool, page);
+       page->in_use = 0;
+       page->offset = 0;
+
        return page;
 }