platform/loongarch: laptop: Add backlight power control support

loongson_laptop_turn_{on,off}_backlight() are designed for controlling
the power of the backlight, but they aren't really used in the driver
previously.

Unify these two functions since they only differ in arguments passed to
ACPI method, and wire up loongson_laptop_backlight_update() to update
the power state of the backlight as well. Tested on the TongFang L860-T2
Loongson-3A5000 laptop.

Cc: stable@vger.kernel.org
Fixes: 6246ed09111f ("LoongArch: Add ACPI-based generic laptop driver")
Signed-off-by: Yao Zi <ziyao@disroot.org>
Signed-off-by: Huacai Chen <chenhuacai@loongson.cn>

diff --git a/drivers/platform/loongarch/loongson-laptop.c b/drivers/platform/loongarch/loongson-laptop.c
index ba9a90818c921034936aa99d372fbd4a4769bf65..9ba4c06252b623fbe8109455f6036de6ace6522f 100644 (file)
--- a/drivers/platform/loongarch/loongson-laptop.c
+++ b/drivers/platform/loongarch/loongson-laptop.c
@@ -56,8 +56,7 @@ static struct input_dev *generic_inputdev;
 static acpi_handle hotkey_handle;
 static struct key_entry hotkey_keycode_map[GENERIC_HOTKEY_MAP_MAX];
 
-int loongson_laptop_turn_on_backlight(void);
-int loongson_laptop_turn_off_backlight(void);
+static bool bl_powered;
 static int loongson_laptop_backlight_update(struct backlight_device *bd);
 
 /* 2. ACPI Helpers and device model */
@@ -354,16 +353,42 @@ static int ec_backlight_level(u8 level)
        return level;
 }
 
+static int ec_backlight_set_power(bool state)
+{
+       int status;
+       union acpi_object arg0 = { ACPI_TYPE_INTEGER };
+       struct acpi_object_list args = { 1, &arg0 };
+
+       arg0.integer.value = state;
+       status = acpi_evaluate_object(NULL, "\\BLSW", &args, NULL);
+       if (ACPI_FAILURE(status)) {
+               pr_info("Loongson lvds error: 0x%x\n", status);
+               return -EIO;
+       }
+
+       return 0;
+}
+
 static int loongson_laptop_backlight_update(struct backlight_device *bd)
 {
-       int lvl = ec_backlight_level(bd->props.brightness);
+       bool target_powered = !backlight_is_blank(bd);
+       int ret = 0, lvl = ec_backlight_level(bd->props.brightness);
 
        if (lvl < 0)
                return -EIO;
+
        if (ec_set_brightness(lvl))
                return -EIO;
 
-       return 0;
+       if (target_powered != bl_powered) {
+               ret = ec_backlight_set_power(target_powered);
+               if (ret < 0)
+                       return ret;
+
+               bl_powered = target_powered;
+       }
+
+       return ret;
 }
 
 static int loongson_laptop_get_brightness(struct backlight_device *bd)
@@ -384,7 +409,7 @@ static const struct backlight_ops backlight_laptop_ops = {
 
 static int laptop_backlight_register(void)
 {
-       int status = 0;
+       int status = 0, ret;
        struct backlight_properties props;
 
        memset(&props, 0, sizeof(props));
@@ -392,44 +417,20 @@ static int laptop_backlight_register(void)
        if (!acpi_evalf(hotkey_handle, &status, "ECLL", "d"))
                return -EIO;
 
+       ret = ec_backlight_set_power(true);
+       if (ret)
+               return ret;
+
+       bl_powered = true;
+
        props.max_brightness = status;
        props.brightness = ec_get_brightness();
+       props.power = BACKLIGHT_POWER_ON;
        props.type = BACKLIGHT_PLATFORM;
 
        backlight_device_register("loongson_laptop",
                                NULL, NULL, &backlight_laptop_ops, &props);
 
-       return 0;
-}
-
-int loongson_laptop_turn_on_backlight(void)
-{
-       int status;
-       union acpi_object arg0 = { ACPI_TYPE_INTEGER };
-       struct acpi_object_list args = { 1, &arg0 };
-
-       arg0.integer.value = 1;
-       status = acpi_evaluate_object(NULL, "\\BLSW", &args, NULL);
-       if (ACPI_FAILURE(status)) {
-               pr_info("Loongson lvds error: 0x%x\n", status);
-               return -ENODEV;
-       }
-
-       return 0;
-}
-
-int loongson_laptop_turn_off_backlight(void)
-{
-       int status;
-       union acpi_object arg0 = { ACPI_TYPE_INTEGER };
-       struct acpi_object_list args = { 1, &arg0 };
-
-       arg0.integer.value = 0;
-       status = acpi_evaluate_object(NULL, "\\BLSW", &args, NULL);
-       if (ACPI_FAILURE(status)) {
-               pr_info("Loongson lvds error: 0x%x\n", status);
-               return -ENODEV;
-       }
 
        return 0;
 }