selftests/bpf: Free inner strings index in btf selftest

Inner array of allocated strings wasn't freed on success. Now it's
always freed.

Signed-off-by: Andrii Nakryiko <andrii@kernel.org>
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Reviewed-by: Hengqi Chen <hengqi.chen@gmail.com>
Link: https://lore.kernel.org/bpf/20211107165521.9240-6-andrii@kernel.org

diff --git a/tools/testing/selftests/bpf/prog_tests/btf.c b/tools/testing/selftests/bpf/prog_tests/btf.c
index ac596cb06e405fac4d5ede78b95f299a2bbe75c0..ebd1aa4d09d646e2839ad2f16f2bcda1cd3dc2e7 100644 (file)
--- a/tools/testing/selftests/bpf/prog_tests/btf.c
+++ b/tools/testing/selftests/bpf/prog_tests/btf.c
@@ -4046,11 +4046,9 @@ static void *btf_raw_create(const struct btf_header *hdr,
                        next_str_idx < strs_cnt ? strs_idx[next_str_idx] : NULL;
 
 done:
+       free(strs_idx);
        if (err) {
-               if (raw_btf)
-                       free(raw_btf);
-               if (strs_idx)
-                       free(strs_idx);
+               free(raw_btf);
                return NULL;
        }
        return raw_btf;