]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
ref_tracker: use %p instead of %px in debugfs dentry name
authorJeff Layton <jlayton@kernel.org>
Fri, 8 Aug 2025 11:45:23 +0000 (07:45 -0400)
committerJakub Kicinski <kuba@kernel.org>
Tue, 12 Aug 2025 03:07:44 +0000 (20:07 -0700)
As Kees points out, this is a kernel address leak, and debugging is
not a sufficiently good reason to expose the real kernel address.

Fixes: 65b584f53611 ("ref_tracker: automatically register a file in debugfs for a ref_tracker_dir")
Reported-by: Kees Cook <kees@kernel.org>
Closes: https://lore.kernel.org/netdev/202507301603.62E553F93@keescook/
Signed-off-by: Jeff Layton <jlayton@kernel.org>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
lib/ref_tracker.c

index a9e6ffcff04b1da162a5a6add6bff075c2c9405e..cce12287708ea43e9eda9fe42f82a80423cea4e3 100644 (file)
@@ -434,7 +434,7 @@ void ref_tracker_dir_debugfs(struct ref_tracker_dir *dir)
        if (dentry && !xa_is_err(dentry))
                return;
 
-       ret = snprintf(name, sizeof(name), "%s@%px", dir->class, dir);
+       ret = snprintf(name, sizeof(name), "%s@%p", dir->class, dir);
        name[sizeof(name) - 1] = '\0';
 
        if (ret < sizeof(name)) {