drm/amdgpu: refine aca error cache for mmhub v1.8

refine aca error cache for mmhub v1.8

Signed-off-by: Yang Wang <kevinyang.wang@amd.com>
Reviewed-by: Hawking Zhang <Hawking.Zhang@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
index bf83e2c08f04e6a8895d3cc4fac917a69cad3a7b..c41f600a5e1020d4d4c58363383c0fed760f9c29 100644 (file)
--- a/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
+++ b/drivers/gpu/drm/amd/amdgpu/mmhub_v1_8.c
@@ -710,27 +710,29 @@ static int mmhub_v1_8_aca_bank_generate_report(struct aca_handle *handle,
                                               struct aca_bank *bank, enum aca_smu_type type,
                                               struct aca_bank_report *report, void *data)
 {
+       struct aca_bank_info info;
        u64 misc0;
        int ret;
 
-       ret = aca_bank_info_decode(bank, &report->info);
+       ret = aca_bank_info_decode(bank, &info);
        if (ret)
                return ret;
 
        misc0 = bank->regs[ACA_REG_IDX_MISC0];
-
        switch (type) {
        case ACA_SMU_TYPE_UE:
-               report->count[ACA_ERROR_TYPE_UE] = 1ULL;
+               ret = aca_error_cache_log_bank_error(handle, &info, ACA_ERROR_TYPE_UE,
+                                                    1ULL);
                break;
        case ACA_SMU_TYPE_CE:
-               report->count[ACA_ERROR_TYPE_CE] = ACA_REG__MISC0__ERRCNT(misc0);
+               ret = aca_error_cache_log_bank_error(handle, &info, ACA_ERROR_TYPE_CE,
+                                                    ACA_REG__MISC0__ERRCNT(misc0));
                break;
        default:
                return -EINVAL;
        }
 
-       return 0;
+       return ret;
 }
 
 /* reference to smu driver if header file */