]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: fsl_pq_mdio: Fix device node reference leak in fsl_pq_mdio_probe
authorErick Karanja <karanja99erick@gmail.com>
Thu, 2 Oct 2025 17:46:17 +0000 (20:46 +0300)
committerJakub Kicinski <kuba@kernel.org>
Mon, 6 Oct 2025 18:22:40 +0000 (11:22 -0700)
Add missing of_node_put call to release device node tbi obtained
via for_each_child_of_node.

Fixes: afae5ad78b342 ("net/fsl_pq_mdio: streamline probing of MDIO nodes")
Signed-off-by: Erick Karanja <karanja99erick@gmail.com>
Link: https://patch.msgid.link/20251002174617.960521-1-karanja99erick@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/freescale/fsl_pq_mdio.c

index 577f9b1780ad6ed1a12705a90c70929328a000b4..de88776dd2a20f428c582faae099f8b1b76b9ef2 100644 (file)
@@ -479,10 +479,12 @@ static int fsl_pq_mdio_probe(struct platform_device *pdev)
                                        "missing 'reg' property in node %pOF\n",
                                        tbi);
                                err = -EBUSY;
+                               of_node_put(tbi);
                                goto error;
                        }
                        set_tbipa(*prop, pdev,
                                  data->get_tbipa, priv->map, &res);
+                       of_node_put(tbi);
                }
        }