]> www.infradead.org Git - users/willy/xarray.git/commitdiff
drm/i915/psr: Print Panel Replay status instead of frame lock status
authorJouni Högander <jouni.hogander@intel.com>
Fri, 7 Jun 2024 13:49:13 +0000 (16:49 +0300)
committerJouni Högander <jouni.hogander@intel.com>
Tue, 11 Jun 2024 10:03:36 +0000 (13:03 +0300)
Currently Panel Replay status printout is printing frame lock status. It
should print Panel Replay status instead. Panel Replay status register
field follows PSR status register field. Use existing PSR code for that.

Fixes: ef75c25e8fed ("drm/i915/panelreplay: Debugfs support for panel replay")
Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Reviewed-by: Animesh Manna <animesh.manna@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20240607134917.1327574-10-jouni.hogander@intel.com
drivers/gpu/drm/i915/display/intel_psr.c

index a0b322dab025a81675f88336cf0be9ada7e2be0d..c3c576defc2bdf1918a61c47f965e24625e6ff28 100644 (file)
@@ -3580,16 +3580,9 @@ static int i915_psr_sink_status_show(struct seq_file *m, void *data)
                "reserved",
                "sink internal error",
        };
-       static const char * const panel_replay_status[] = {
-               "Sink device frame is locked to the Source device",
-               "Sink device is coasting, using the VTotal target",
-               "Sink device is governing the frame rate (frame rate unlock is granted)",
-               "Sink device in the process of re-locking with the Source device",
-       };
        const char *str;
        int ret;
        u8 status, error_status;
-       u32 idx;
 
        if (!(CAN_PSR(intel_dp) || CAN_PANEL_REPLAY(intel_dp))) {
                seq_puts(m, "PSR/Panel-Replay Unsupported\n");
@@ -3603,16 +3596,11 @@ static int i915_psr_sink_status_show(struct seq_file *m, void *data)
        if (ret)
                return ret;
 
-       str = "unknown";
-       if (intel_dp->psr.panel_replay_enabled) {
-               idx = (status & DP_SINK_FRAME_LOCKED_MASK) >> DP_SINK_FRAME_LOCKED_SHIFT;
-               if (idx < ARRAY_SIZE(panel_replay_status))
-                       str = panel_replay_status[idx];
-       } else if (intel_dp->psr.enabled) {
-               idx = status & DP_PSR_SINK_STATE_MASK;
-               if (idx < ARRAY_SIZE(sink_status))
-                       str = sink_status[idx];
-       }
+       status &= DP_PSR_SINK_STATE_MASK;
+       if (status < ARRAY_SIZE(sink_status))
+               str = sink_status[status];
+       else
+               str = "unknown";
 
        seq_printf(m, "Sink %s status: 0x%x [%s]\n", psr_mode_str(intel_dp), status, str);