netfilter: nf_tables: typo NULL check in _clone() function

This should check for NULL in case memory allocation fails.

Reported-by: Julian Wiedmann <jwiedmann.dev@gmail.com>
Fixes: 3b9e2ea6c11b ("netfilter: nft_limit: move stateful fields out of expression data")
Fixes: 37f319f37d90 ("netfilter: nft_connlimit: move stateful fields out of expression data")
Fixes: 33a24de37e81 ("netfilter: nft_last: move stateful fields out of expression data")
Fixes: ed0a0c60f0e5 ("netfilter: nft_quota: move stateful fields out of expression data")
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Link: https://lore.kernel.org/r/20220110194817.53481-1-pablo@netfilter.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

diff --git a/net/netfilter/nft_connlimit.c b/net/netfilter/nft_connlimit.c
index 58dcafe8bf7946c012742f43cc6cca5dc7c26e88..7d00a1452b1d29ae993fc059d356cfec0e04bf50 100644 (file)
--- a/net/netfilter/nft_connlimit.c
+++ b/net/netfilter/nft_connlimit.c
@@ -206,7 +206,7 @@ static int nft_connlimit_clone(struct nft_expr *dst, const struct nft_expr *src)
        struct nft_connlimit *priv_src = nft_expr_priv(src);
 
        priv_dst->list = kmalloc(sizeof(*priv_dst->list), GFP_ATOMIC);
-       if (priv_dst->list)
+       if (!priv_dst->list)
                return -ENOMEM;
 
        nf_conncount_list_init(priv_dst->list);

diff --git a/net/netfilter/nft_last.c b/net/netfilter/nft_last.c
index 5ee33d0ccd4ea4bf202f6d3316adab49b0c0a109..4f745a409d347c231c30cb88aba840009295e231 100644 (file)
--- a/net/netfilter/nft_last.c
+++ b/net/netfilter/nft_last.c
@@ -106,7 +106,7 @@ static int nft_last_clone(struct nft_expr *dst, const struct nft_expr *src)
        struct nft_last_priv *priv_dst = nft_expr_priv(dst);
 
        priv_dst->last = kzalloc(sizeof(*priv_dst->last), GFP_ATOMIC);
-       if (priv_dst->last)
+       if (!priv_dst->last)
                return -ENOMEM;
 
        return 0;

diff --git a/net/netfilter/nft_limit.c b/net/netfilter/nft_limit.c
index f04be5be73a0c6100f89d5eff05673086af7c428..c4f308460dd1d469a9c7d5c748226d882d45c266 100644 (file)
--- a/net/netfilter/nft_limit.c
+++ b/net/netfilter/nft_limit.c
@@ -145,7 +145,7 @@ static int nft_limit_clone(struct nft_limit_priv *priv_dst,
        priv_dst->invert = priv_src->invert;
 
        priv_dst->limit = kmalloc(sizeof(*priv_dst->limit), GFP_ATOMIC);
-       if (priv_dst->limit)
+       if (!priv_dst->limit)
                return -ENOMEM;
 
        spin_lock_init(&priv_dst->limit->lock);

diff --git a/net/netfilter/nft_quota.c b/net/netfilter/nft_quota.c
index 0484aef74273b08c04c339bd7fe7a9e8ae693ed2..f394a0b562f66f36a3b63066471125de5bcb2709 100644 (file)
--- a/net/netfilter/nft_quota.c
+++ b/net/netfilter/nft_quota.c
@@ -237,7 +237,7 @@ static int nft_quota_clone(struct nft_expr *dst, const struct nft_expr *src)
        struct nft_quota *priv_dst = nft_expr_priv(dst);
 
        priv_dst->consumed = kmalloc(sizeof(*priv_dst->consumed), GFP_ATOMIC);
-       if (priv_dst->consumed)
+       if (!priv_dst->consumed)
                return -ENOMEM;
 
        atomic64_set(priv_dst->consumed, 0);