]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: dsa: avoid refcount warnings when ds->ops->tag_8021q_vlan_del() fails
authorVladimir Oltean <vladimir.oltean@nxp.com>
Mon, 14 Apr 2025 21:30:20 +0000 (00:30 +0300)
committerJakub Kicinski <kuba@kernel.org>
Thu, 17 Apr 2025 01:14:44 +0000 (18:14 -0700)
This is very similar to the problem and solution from commit
232deb3f9567 ("net: dsa: avoid refcount warnings when
->port_{fdb,mdb}_del returns error"), except for the
dsa_port_do_tag_8021q_vlan_del() operation.

Fixes: c64b9c05045a ("net: dsa: tag_8021q: add proper cross-chip notifier support")
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Link: https://patch.msgid.link/20250414213020.2959021-1-vladimir.oltean@nxp.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/dsa/tag_8021q.c

index 3ee53e28ec2e9f550b54d438cca26b0a34fd5fe4..53e03fd8071b4a27117d4cb0c1bdc0a103eeed92 100644 (file)
@@ -197,7 +197,7 @@ static int dsa_port_do_tag_8021q_vlan_del(struct dsa_port *dp, u16 vid)
 
        err = ds->ops->tag_8021q_vlan_del(ds, port, vid);
        if (err) {
-               refcount_inc(&v->refcount);
+               refcount_set(&v->refcount, 1);
                return err;
        }