]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ovl: Use str_on_off() helper in ovl_show_options()
authorThorsten Blum <thorsten.blum@linux.dev>
Mon, 14 Apr 2025 20:54:08 +0000 (22:54 +0200)
committerMiklos Szeredi <mszeredi@redhat.com>
Wed, 30 Apr 2025 08:55:27 +0000 (10:55 +0200)
Remove hard-coded strings by using the str_on_off() helper function.

Acked-by: Amir Goldstein <amir73il@gmail.com>
Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev>
Signed-off-by: Miklos Szeredi <mszeredi@redhat.com>
fs/overlayfs/params.c

index e297681ecac7a5c9830991154754f04346defcc2..f42488c019572479d8fdcfc1efd62b21d2995875 100644 (file)
@@ -1051,17 +1051,16 @@ int ovl_show_options(struct seq_file *m, struct dentry *dentry)
                seq_printf(m, ",redirect_dir=%s",
                           ovl_redirect_mode(&ofs->config));
        if (ofs->config.index != ovl_index_def)
-               seq_printf(m, ",index=%s", ofs->config.index ? "on" : "off");
+               seq_printf(m, ",index=%s", str_on_off(ofs->config.index));
        if (ofs->config.uuid != ovl_uuid_def())
                seq_printf(m, ",uuid=%s", ovl_uuid_mode(&ofs->config));
        if (ofs->config.nfs_export != ovl_nfs_export_def)
-               seq_printf(m, ",nfs_export=%s", ofs->config.nfs_export ?
-                                               "on" : "off");
+               seq_printf(m, ",nfs_export=%s",
+                          str_on_off(ofs->config.nfs_export));
        if (ofs->config.xino != ovl_xino_def() && !ovl_same_fs(ofs))
                seq_printf(m, ",xino=%s", ovl_xino_mode(&ofs->config));
        if (ofs->config.metacopy != ovl_metacopy_def)
-               seq_printf(m, ",metacopy=%s",
-                          ofs->config.metacopy ? "on" : "off");
+               seq_printf(m, ",metacopy=%s", str_on_off(ofs->config.metacopy));
        if (ofs->config.ovl_volatile)
                seq_puts(m, ",volatile");
        if (ofs->config.userxattr)