]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
Revert "igb: Disable threaded IRQ for igb_msix_other"
authorWander Lairson Costa <wander@redhat.com>
Wed, 6 Nov 2024 11:14:26 +0000 (08:14 -0300)
committerJakub Kicinski <kuba@kernel.org>
Wed, 13 Nov 2024 02:05:40 +0000 (18:05 -0800)
This reverts commit 338c4d3902feb5be49bfda530a72c7ab860e2c9f.

Sebastian noticed the ISR indirectly acquires spin_locks, which are
sleeping locks under PREEMPT_RT, which leads to kernel splats.

Fixes: 338c4d3902feb ("igb: Disable threaded IRQ for igb_msix_other")
Reported-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Signed-off-by: Wander Lairson Costa <wander@redhat.com>
Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Acked-by: Przemek Kitszel <przemyslaw.kitszel@intel.com>
Link: https://patch.msgid.link/20241106111427.7272-1-wander@redhat.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/intel/igb/igb_main.c

index b83df5f94b1f57d3b8f0000798aef0dd15521f62..f1d0881687233eaae024f0bb9617b0a30a1f12b2 100644 (file)
@@ -907,7 +907,7 @@ static int igb_request_msix(struct igb_adapter *adapter)
        int i, err = 0, vector = 0, free_vector = 0;
 
        err = request_irq(adapter->msix_entries[vector].vector,
-                         igb_msix_other, IRQF_NO_THREAD, netdev->name, adapter);
+                         igb_msix_other, 0, netdev->name, adapter);
        if (err)
                goto err_out;