aspeed/sdmc: Remove extra R_MAIN_STATUS case
authorJamin Lin <jamin_lin@aspeedtech.com>
Tue, 25 Jun 2024 07:07:40 +0000 (15:07 +0800)
committerCédric Le Goater <clg@redhat.com>
Tue, 2 Jul 2024 05:52:43 +0000 (07:52 +0200)
Coverity reports that the newly added 'case R_MAIN_STATUS' is DEADCODE
because it can not be reached. This is because R_MAIN_STATUS is handled
before in the "Unprotected registers" switch statement. Remove it.

Fixes: Coverity CID 1547112
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
Reviewed-by: Cédric Le Goater <clg@redhat.com>
[ clg: Rewrote commit log ]
Signed-off-by: Cédric Le Goater <clg@redhat.com>
hw/misc/aspeed_sdmc.c

index 44da085e10cb0707ed937ef2c0353bb511975c12..ebf139cb5c91b38ec88c71a285b114cd2b09454a 100644 (file)
@@ -595,7 +595,6 @@ static void aspeed_2700_sdmc_write(AspeedSDMCState *s, uint32_t reg,
     case R_INT_STATUS:
     case R_INT_CLEAR:
     case R_INT_MASK:
-    case R_MAIN_STATUS:
     case R_ERR_STATUS:
     case R_ECC_FAIL_STATUS:
     case R_ECC_FAIL_ADDR: