]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
NTB: perf: Fix support for hardware that doesn't have port numbers
authorLogan Gunthorpe <logang@deltatee.com>
Wed, 9 Jan 2019 19:22:31 +0000 (12:22 -0700)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 24 Jun 2020 15:50:41 +0000 (17:50 +0200)
[ Upstream commit b54369a248c2e033bfcf5d6917e08cf9d73d54a6 ]

Legacy drivers do not have port numbers (but is reliably only two ports)
and was broken by the recent commit that added mult-port support to
ntb_perf. This is especially important to support the cross link
topology which is perfectly symmetric and cannot assign unique port
numbers easily.

Hardware that returns zero for both the local port and the peer should
just always use gidx=0 for the only peer.

Fixes: 5648e56d03fa ("NTB: ntb_perf: Add full multi-port NTB API support")
Signed-off-by: Logan Gunthorpe <logang@deltatee.com>
Acked-by: Allen Hubbe <allenbh@gmail.com>
Tested-by: Alexander Fomichev <fomichev.ru@gmail.com>
Signed-off-by: Jon Mason <jdmason@kudzu.us>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/ntb/test/ntb_perf.c

index 3817eadab2cf97eab85a62fefe765b738eee1f4d..281170887ad06d5930ed4579a6ba15f91f2f0d22 100644 (file)
@@ -1423,6 +1423,16 @@ static int perf_init_peers(struct perf_ctx *perf)
        if (perf->gidx == -1)
                perf->gidx = pidx;
 
+       /*
+        * Hardware with only two ports may not have unique port
+        * numbers. In this case, the gidxs should all be zero.
+        */
+       if (perf->pcnt == 1 &&  ntb_port_number(perf->ntb) == 0 &&
+           ntb_peer_port_number(perf->ntb, 0) == 0) {
+               perf->gidx = 0;
+               perf->peers[0].gidx = 0;
+       }
+
        for (pidx = 0; pidx < perf->pcnt; pidx++) {
                ret = perf_setup_peer_mw(&perf->peers[pidx]);
                if (ret)