ALSA: core: Drop snd_print stuff and co

Now that all users of snd_print*() are gone, let's drop the functions
completely.  This also makes CONFIG_SND_VERBOSE_PRINTK redundant, and
it's dropped, too.

Reviewed-by: Jaroslav Kysela <perex@perex.cz>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Link: https://patch.msgid.link/20240807133452.9424-55-tiwai@suse.de

diff --git a/include/sound/core.h b/include/sound/core.h
index dfef0c9d4b9f7ee74d24e7e85e10e2e3f8e50833..23401aaf3dc2438395452ab7b3643b4bafd6b64b 100644 (file)
--- a/include/sound/core.h
+++ b/include/sound/core.h
@@ -345,45 +345,7 @@ void release_and_free_resource(struct resource *res);
 
 /* --- */
 
-/* sound printk debug levels */
-enum {
-       SND_PR_ALWAYS,
-       SND_PR_DEBUG,
-       SND_PR_VERBOSE,
-};
-
-#if defined(CONFIG_SND_DEBUG) || defined(CONFIG_SND_VERBOSE_PRINTK)
-__printf(4, 5)
-void __snd_printk(unsigned int level, const char *file, int line,
-                 const char *format, ...);
-#else
-#define __snd_printk(level, file, line, format, ...) \
-       printk(format, ##__VA_ARGS__)
-#endif
-
-/**
- * snd_printk - printk wrapper
- * @fmt: format string
- *
- * Works like printk() but prints the file and the line of the caller
- * when configured with CONFIG_SND_VERBOSE_PRINTK.
- */
-#define snd_printk(fmt, ...) \
-       __snd_printk(0, __FILE__, __LINE__, fmt, ##__VA_ARGS__)
-
 #ifdef CONFIG_SND_DEBUG
-/**
- * snd_printd - debug printk
- * @fmt: format string
- *
- * Works like snd_printk() for debugging purposes.
- * Ignored when CONFIG_SND_DEBUG is not set.
- */
-#define snd_printd(fmt, ...) \
-       __snd_printk(1, __FILE__, __LINE__, fmt, ##__VA_ARGS__)
-#define _snd_printd(level, fmt, ...) \
-       __snd_printk(level, __FILE__, __LINE__, fmt, ##__VA_ARGS__)
-
 /**
  * snd_BUG - give a BUG warning message and stack trace
  *
@@ -392,12 +354,6 @@ void __snd_printk(unsigned int level, const char *file, int line,
  */
 #define snd_BUG()              WARN(1, "BUG?\n")
 
-/**
- * snd_printd_ratelimit - Suppress high rates of output when
- *                       CONFIG_SND_DEBUG is enabled.
- */
-#define snd_printd_ratelimit() printk_ratelimit()
-
 /**
  * snd_BUG_ON - debugging check macro
  * @cond: condition to evaluate
@@ -409,11 +365,6 @@ void __snd_printk(unsigned int level, const char *file, int line,
 
 #else /* !CONFIG_SND_DEBUG */
 
-__printf(1, 2)
-static inline void snd_printd(const char *format, ...) {}
-__printf(2, 3)
-static inline void _snd_printd(int level, const char *format, ...) {}
-
 #define snd_BUG()                      do { } while (0)
 
 #define snd_BUG_ON(condition) ({ \
@@ -421,26 +372,8 @@ static inline void _snd_printd(int level, const char *format, ...) {}
        unlikely(__ret_warn_on); \
 })
 
-static inline bool snd_printd_ratelimit(void) { return false; }
-
 #endif /* CONFIG_SND_DEBUG */
 
-#ifdef CONFIG_SND_DEBUG_VERBOSE
-/**
- * snd_printdd - debug printk
- * @format: format string
- *
- * Works like snd_printk() for debugging purposes.
- * Ignored when CONFIG_SND_DEBUG_VERBOSE is not set.
- */
-#define snd_printdd(format, ...) \
-       __snd_printk(2, __FILE__, __LINE__, format, ##__VA_ARGS__)
-#else
-__printf(1, 2)
-static inline void snd_printdd(const char *format, ...) {}
-#endif
-
-
 #define SNDRV_OSS_VERSION         ((3<<16)|(8<<8)|(1<<4)|(0))  /* 3.8.1a */
 
 /* for easier backward-porting */

diff --git a/sound/core/Kconfig b/sound/core/Kconfig
index b970a173464708ff1d3abfeff71080a99963fd14..f0ba87d4e504601ad3baf80959d4b4ffdd3afacc 100644 (file)
--- a/sound/core/Kconfig
+++ b/sound/core/Kconfig
@@ -175,15 +175,6 @@ config SND_VERBOSE_PROCFS
          useful information to developers when a problem occurs).  On the
          other side, it makes the ALSA subsystem larger.
 
-config SND_VERBOSE_PRINTK
-       bool "Verbose printk"
-       help
-         Say Y here to enable verbose log messages.  These messages
-         will help to identify source file and position containing
-         printed messages.
-
-         You don't need this unless you're debugging ALSA.
-
 config SND_CTL_FAST_LOOKUP
        bool "Fast lookup of control elements" if EXPERT
        default y

diff --git a/sound/core/misc.c b/sound/core/misc.c
index d32a19976a2b9543e660478295787f532e3c8925..c2fda3bd90a0d4c8ed6bf23e4e1206ef6c1712e3 100644 (file)
--- a/sound/core/misc.c
+++ b/sound/core/misc.c
@@ -13,20 +13,6 @@
 #include <linux/fs.h>
 #include <sound/core.h>
 
-#ifdef CONFIG_SND_DEBUG
-
-#ifdef CONFIG_SND_DEBUG_VERBOSE
-#define DEFAULT_DEBUG_LEVEL    2
-#else
-#define DEFAULT_DEBUG_LEVEL    1
-#endif
-
-static int debug = DEFAULT_DEBUG_LEVEL;
-module_param(debug, int, 0644);
-MODULE_PARM_DESC(debug, "Debug level (0 = disable)");
-
-#endif /* CONFIG_SND_DEBUG */
-
 void release_and_free_resource(struct resource *res)
 {
        if (res) {
@@ -36,63 +22,6 @@ void release_and_free_resource(struct resource *res)
 }
 EXPORT_SYMBOL(release_and_free_resource);
 
-#ifdef CONFIG_SND_VERBOSE_PRINTK
-/* strip the leading path if the given path is absolute */
-static const char *sanity_file_name(const char *path)
-{
-       if (*path == '/')
-               return strrchr(path, '/') + 1;
-       else
-               return path;
-}
-#endif
-
-#if defined(CONFIG_SND_DEBUG) || defined(CONFIG_SND_VERBOSE_PRINTK)
-void __snd_printk(unsigned int level, const char *path, int line,
-                 const char *format, ...)
-{
-       va_list args;
-#ifdef CONFIG_SND_VERBOSE_PRINTK
-       int kern_level;
-       struct va_format vaf;
-       char verbose_fmt[] = KERN_DEFAULT "ALSA %s:%d %pV";
-       bool level_found = false;
-#endif
-
-#ifdef CONFIG_SND_DEBUG
-       if (debug < level)
-               return;
-#endif
-
-       va_start(args, format);
-#ifdef CONFIG_SND_VERBOSE_PRINTK
-       vaf.fmt = format;
-       vaf.va = &args;
-
-       while ((kern_level = printk_get_level(vaf.fmt)) != 0) {
-               const char *end_of_header = printk_skip_level(vaf.fmt);
-
-               /* Ignore KERN_CONT. We print filename:line for each piece. */
-               if (kern_level >= '0' && kern_level <= '7') {
-                       memcpy(verbose_fmt, vaf.fmt, end_of_header - vaf.fmt);
-                       level_found = true;
-               }
-
-               vaf.fmt = end_of_header;
-       }
-
-       if (!level_found && level)
-               memcpy(verbose_fmt, KERN_DEBUG, sizeof(KERN_DEBUG) - 1);
-
-       printk(verbose_fmt, sanity_file_name(path), line, &vaf);
-#else
-       vprintk(format, args);
-#endif
-       va_end(args);
-}
-EXPORT_SYMBOL_GPL(__snd_printk);
-#endif
-
 #ifdef CONFIG_PCI
 #include <linux/pci.h>
 /**