]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
Input: imx6ul_tsc - set glitch threshold by DTS property
authorDario Binacchi <dario.binacchi@amarulasolutions.com>
Tue, 23 Sep 2025 14:37:37 +0000 (16:37 +0200)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 24 Sep 2025 21:21:13 +0000 (14:21 -0700)
Set the glitch threshold by DTS property and keep the existing default
behavior if the 'debounce-delay-us' is not present.

Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
Reviewed-by: Frank Li <Frank.Li@nxp.com>
Link: https://lore.kernel.org/r/20250923143746.2857292-7-dario.binacchi@amarulasolutions.com
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/touchscreen/imx6ul_tsc.c

index e2c59cc7c82c87aaac4319ceb2352e67ce58a014..85f697de2b7e29a7698df59d044785a6a43033fb 100644 (file)
@@ -79,7 +79,7 @@
 #define MEASURE_SIG_EN         BIT(0)
 #define VALID_SIG_EN           BIT(8)
 #define DE_GLITCH_MASK         GENMASK(30, 29)
-#define DE_GLITCH_2            0x02
+#define DE_GLITCH_DEF          0x02
 #define START_SENSE            BIT(12)
 #define TSC_DISABLE            BIT(16)
 #define DETECT_MODE            0x2
@@ -98,6 +98,7 @@ struct imx6ul_tsc {
        u32 pre_charge_time;
        bool average_enable;
        u32 average_select;
+       u32 de_glitch;
 
        struct completion completion;
 };
@@ -205,7 +206,7 @@ static void imx6ul_tsc_set(struct imx6ul_tsc *tsc)
        basic_setting |= AUTO_MEASURE;
        writel(basic_setting, tsc->tsc_regs + REG_TSC_BASIC_SETTING);
 
-       debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, DE_GLITCH_2);
+       debug_mode2 = FIELD_PREP(DE_GLITCH_MASK, tsc->de_glitch);
        writel(debug_mode2, tsc->tsc_regs + REG_TSC_DEBUG_MODE2);
 
        writel(tsc->pre_charge_time, tsc->tsc_regs + REG_TSC_PRE_CHARGE_TIME);
@@ -391,6 +392,7 @@ static int imx6ul_tsc_probe(struct platform_device *pdev)
        int tsc_irq;
        int adc_irq;
        u32 average_samples;
+       u32 de_glitch;
 
        tsc = devm_kzalloc(&pdev->dev, sizeof(*tsc), GFP_KERNEL);
        if (!tsc)
@@ -513,6 +515,25 @@ static int imx6ul_tsc_probe(struct platform_device *pdev)
                return -EINVAL;
        }
 
+       err = of_property_read_u32(np, "debounce-delay-us", &de_glitch);
+       if (err) {
+               tsc->de_glitch = DE_GLITCH_DEF;
+       } else {
+               u64 cycles;
+               unsigned long rate = clk_get_rate(tsc->tsc_clk);
+
+               cycles = DIV64_U64_ROUND_UP((u64)de_glitch * rate, USEC_PER_SEC);
+
+               if (cycles <= 0x3ff)
+                       tsc->de_glitch = 3;
+               else if (cycles <= 0x7ff)
+                       tsc->de_glitch = 2;
+               else if (cycles <= 0xfff)
+                       tsc->de_glitch = 1;
+               else
+                       tsc->de_glitch = 0;
+       }
+
        err = input_register_device(tsc->input);
        if (err) {
                dev_err(&pdev->dev,