fsi: master-ast-cf: Fix memory leak

In case memory resources for *fw* were allocated, release them
before return.

Addresses-Coverity-ID: 1472044 ("Resource leak")
Fixes: 6a794a27daca ("fsi: master-ast-cf: Add new FSI master using Aspeed ColdFire")
Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>

diff --git a/drivers/fsi/fsi-master-ast-cf.c b/drivers/fsi/fsi-master-ast-cf.c
index b59abcf3ee321f59ced513cf3d9cf8b80411f257..6a36220e4b400750cb8def5053597a01bf5fa8aa 100644 (file)
--- a/drivers/fsi/fsi-master-ast-cf.c
+++ b/drivers/fsi/fsi-master-ast-cf.c
@@ -861,7 +861,8 @@ static int load_copro_firmware(struct fsi_master_acf *master)
        if (sig != wanted_sig) {
                dev_err(master->dev, "Failed to locate image sig %04x in FW blob\n",
                        wanted_sig);
-               return -ENODEV;
+               rc = -ENODEV;
+               goto release_fw;
        }
        if (size > master->cf_mem_size) {
                dev_err(master->dev, "FW size (%zd) bigger than memory reserve (%zd)\n",
@@ -870,8 +871,9 @@ static int load_copro_firmware(struct fsi_master_acf *master)
        } else {
                memcpy_toio(master->cf_mem, data, size);
        }
-       release_firmware(fw);
 
+release_fw:
+       release_firmware(fw);
        return rc;
 }