]> www.infradead.org Git - users/hch/xfs.git/commitdiff
xfs: use kfree_rcu_mightsleep to free the perag structures
authorChristoph Hellwig <hch@lst.de>
Thu, 29 Aug 2024 04:08:37 +0000 (07:08 +0300)
committerChandan Babu R <chandanbabu@kernel.org>
Tue, 3 Sep 2024 04:37:43 +0000 (10:07 +0530)
Using the kfree_rcu_mightsleep is simpler and removes the need for a
rcu_head in the perag structure.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Chandan Babu R <chandanbabu@kernel.org>
fs/xfs/libxfs/xfs_ag.c
fs/xfs/libxfs/xfs_ag.h

index 7e80732cb54708c56cb2e22d9265a4cefcb75e25..4b5a39a83f7aedecd777abefd77383fa695408f3 100644 (file)
@@ -235,16 +235,6 @@ out:
        return error;
 }
 
-STATIC void
-__xfs_free_perag(
-       struct rcu_head *head)
-{
-       struct xfs_perag *pag = container_of(head, struct xfs_perag, rcu_head);
-
-       ASSERT(!delayed_work_pending(&pag->pag_blockgc_work));
-       kfree(pag);
-}
-
 /*
  * Free up the per-ag resources associated with the mount structure.
  */
@@ -270,7 +260,7 @@ xfs_free_perag(
                xfs_perag_rele(pag);
                XFS_IS_CORRUPT(pag->pag_mount,
                                atomic_read(&pag->pag_active_ref) != 0);
-               call_rcu(&pag->rcu_head, __xfs_free_perag);
+               kfree_rcu_mightsleep(pag);
        }
 }
 
index 35de09a2516c704b87af86bd3e33ad8ff1768196..d62c266c0b44d54942003921d7b8180a1d06c53c 100644 (file)
@@ -63,9 +63,6 @@ struct xfs_perag {
        /* Blocks reserved for the reverse mapping btree. */
        struct xfs_ag_resv      pag_rmapbt_resv;
 
-       /* for rcu-safe freeing */
-       struct rcu_head rcu_head;
-
        /* Precalculated geometry info */
        xfs_agblock_t           block_count;
        xfs_agblock_t           min_block;