]> www.infradead.org Git - users/hch/misc.git/commitdiff
ALSA: lx_core: use int type to store negative error codes
authorQianfeng Rong <rongqianfeng@vivo.com>
Thu, 28 Aug 2025 08:13:10 +0000 (16:13 +0800)
committerTakashi Iwai <tiwai@suse.de>
Thu, 28 Aug 2025 08:35:09 +0000 (10:35 +0200)
Change the 'ret' variable from u16 to int to store negative error codes or
zero returned by lx_message_send_atomic().

Storing the negative error codes in unsigned type, doesn't cause an issue
at runtime but it's ugly as pants. Additionally, assigning negative error
codes to unsigned type may trigger a GCC warning when the -Wsign-conversion
flag is enabled.

No effect on runtime.

Fixes: 02bec4904508 ("ALSA: lx6464es - driver for the digigram lx6464es interface")
Signed-off-by: Qianfeng Rong <rongqianfeng@vivo.com>
Link: https://patch.msgid.link/20250828081312.393148-1-rongqianfeng@vivo.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/lx6464es/lx_core.c

index 9d95ecb299aed87350452f6c4bd7dd58cfbbe150..a99acd1125e74f076f8791e0a6e26fd444f9a50d 100644 (file)
@@ -316,7 +316,7 @@ polling_successful:
 /* low-level dsp access */
 int lx_dsp_get_version(struct lx6464es *chip, u32 *rdsp_version)
 {
-       u16 ret;
+       int ret;
 
        mutex_lock(&chip->msg_lock);
 
@@ -330,10 +330,10 @@ int lx_dsp_get_version(struct lx6464es *chip, u32 *rdsp_version)
 
 int lx_dsp_get_clock_frequency(struct lx6464es *chip, u32 *rfreq)
 {
-       u16 ret = 0;
        u32 freq_raw = 0;
        u32 freq = 0;
        u32 frequency = 0;
+       int ret;
 
        mutex_lock(&chip->msg_lock);