]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
crypto: sa2ul - Fix pm_runtime_get_sync() error checking
authorDan Carpenter <dan.carpenter@oracle.com>
Wed, 9 Sep 2020 09:45:28 +0000 (12:45 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 29 Oct 2020 09:11:07 +0000 (10:11 +0100)
[ Upstream commit 2baace5feb86c6916221911f391f11fcd8e1a259 ]

The pm_runtime_get_sync() function returns either 0 or 1 on success but
this code treats a return of 1 as a failure.

Fixes: 7694b6ca649f ("crypto: sa2ul - Add crypto driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/crypto/sa2ul.c

index ff8bbdb4d235dafd4671ca6045f9672317643c0d..039579b7cc81833822c53f88e72a159b5096a9f4 100644 (file)
@@ -2331,7 +2331,7 @@ static int sa_ul_probe(struct platform_device *pdev)
 
        pm_runtime_enable(dev);
        ret = pm_runtime_get_sync(dev);
-       if (ret) {
+       if (ret < 0) {
                dev_err(&pdev->dev, "%s: failed to get sync: %d\n", __func__,
                        ret);
                return ret;