]> www.infradead.org Git - users/hch/block.git/commitdiff
coresight: etm4x: Skip setting LPOVERRIDE bit for qcom,skip-power-up
authorSai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Fri, 16 Oct 2020 10:10:25 +0000 (15:40 +0530)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Mon, 26 Oct 2020 20:07:35 +0000 (14:07 -0600)
There is a bug on the systems supporting to skip power up
(qcom,skip-power-up) where setting LPOVERRIDE bit(low-power
state override behaviour) will result in CPU hangs/lockups
even on the implementations which supports it. So skip
setting the LPOVERRIDE bit for such platforms.

Fixes: 02510a5aa78d ("coresight: etm4x: Add support to skip trace unit power up")
Signed-off-by: Sai Prakash Ranjan <saiprakash.ranjan@codeaurora.org>
Reviewed-by: Suzuki K Poulose <suzuki.poulose@arm.com>
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/hwtracing/coresight/coresight-etm4x-core.c

index abd706b216ac909ff98a7555538dece54f183e86..6096d7abf80d2dcdd8f2c96b5c70244bdc222cd3 100644 (file)
@@ -779,7 +779,7 @@ static void etm4_init_arch_data(void *info)
         * LPOVERRIDE, bit[23] implementation supports
         * low-power state override
         */
-       if (BMVAL(etmidr5, 23, 23))
+       if (BMVAL(etmidr5, 23, 23) && (!drvdata->skip_power_up))
                drvdata->lpoverride = true;
        else
                drvdata->lpoverride = false;