]> www.infradead.org Git - users/hch/xfs.git/commitdiff
vboxsf: fix building with GCC 15
authorBrahmajit Das <brahmajit.xyz@gmail.com>
Tue, 21 Jan 2025 16:26:48 +0000 (21:56 +0530)
committerChristian Brauner <brauner@kernel.org>
Fri, 7 Feb 2025 09:27:24 +0000 (10:27 +0100)
Building with GCC 15 results in build error
fs/vboxsf/super.c:24:54: error: initializer-string for array of â€˜unsigned char’ is too long [-Werror=unterminated-string-initialization]
   24 | static const unsigned char VBSF_MOUNT_SIGNATURE[4] = "\000\377\376\375";
      |                                                      ^~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors

Due to GCC having enabled -Werror=unterminated-string-initialization[0]
by default. Separately initializing each array element of
VBSF_MOUNT_SIGNATURE to ensure NUL termination, thus satisfying GCC 15
and fixing the build error.

[0]: https://gcc.gnu.org/onlinedocs/gcc/Warning-Options.html#index-Wno-unterminated-string-initialization

Signed-off-by: Brahmajit Das <brahmajit.xyz@gmail.com>
Link: https://lore.kernel.org/r/20250121162648.1408743-1-brahmajit.xyz@gmail.com
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/vboxsf/super.c

index e95b8a48d8a02df3e6d23fd5b4fa09c12fc876d3..1d94bb7841081d0a92535a0b74bd6f7106187459 100644 (file)
@@ -21,7 +21,8 @@
 
 #define VBOXSF_SUPER_MAGIC 0x786f4256 /* 'VBox' little endian */
 
-static const unsigned char VBSF_MOUNT_SIGNATURE[4] = "\000\377\376\375";
+static const unsigned char VBSF_MOUNT_SIGNATURE[4] = { '\000', '\377', '\376',
+                                                      '\375' };
 
 static int follow_symlinks;
 module_param(follow_symlinks, int, 0444);