]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/panel: xinpeng-xpp055c272: Stop tracking prepared
authorDouglas Anderson <dianders@chromium.org>
Fri, 3 May 2024 21:33:11 +0000 (14:33 -0700)
committerDouglas Anderson <dianders@chromium.org>
Tue, 28 May 2024 20:09:11 +0000 (13:09 -0700)
As talked about in commit d2aacaf07395 ("drm/panel: Check for already
prepared/enabled in drm_panel"), we want to remove needless code from
panel drivers that was storing and double-checking the
prepared/enabled state. Even if someone was relying on the
double-check before, that double-check is now in the core and not
needed in individual drivers.

Acked-by: Linus Walleij <linus.walleij@linaro.org>
Acked-by: Maxime Ripard <mripard@kernel.org>
Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Douglas Anderson <dianders@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20240503143327.RFT.v2.30.I2145be78ce28327f4588c2c21370f22fd79d28b8@changeid
drivers/gpu/drm/panel/panel-xinpeng-xpp055c272.c

index 8670386498a48e772a10b77f5c96626d4122fa43..8262c00670cf88b667c3855f8819dfcda7827ad2 100644 (file)
@@ -52,7 +52,6 @@ struct xpp055c272 {
        struct gpio_desc *reset_gpio;
        struct regulator *vci;
        struct regulator *iovcc;
-       bool prepared;
 };
 
 static inline struct xpp055c272 *panel_to_xpp055c272(struct drm_panel *panel)
@@ -136,9 +135,6 @@ static int xpp055c272_unprepare(struct drm_panel *panel)
        struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
        int ret;
 
-       if (!ctx->prepared)
-               return 0;
-
        ret = mipi_dsi_dcs_set_display_off(dsi);
        if (ret < 0)
                dev_err(ctx->dev, "failed to set display off: %d\n", ret);
@@ -152,8 +148,6 @@ static int xpp055c272_unprepare(struct drm_panel *panel)
        regulator_disable(ctx->iovcc);
        regulator_disable(ctx->vci);
 
-       ctx->prepared = false;
-
        return 0;
 }
 
@@ -163,9 +157,6 @@ static int xpp055c272_prepare(struct drm_panel *panel)
        struct mipi_dsi_device *dsi = to_mipi_dsi_device(ctx->dev);
        int ret;
 
-       if (ctx->prepared)
-               return 0;
-
        dev_dbg(ctx->dev, "Resetting the panel\n");
        ret = regulator_enable(ctx->vci);
        if (ret < 0) {
@@ -209,8 +200,6 @@ static int xpp055c272_prepare(struct drm_panel *panel)
 
        msleep(50);
 
-       ctx->prepared = true;
-
        return 0;
 
 disable_iovcc: