]> www.infradead.org Git - users/hch/misc.git/commitdiff
net: hibmcge: fix wrong mtu log issue
authorJijie Shao <shaojijie@huawei.com>
Thu, 10 Apr 2025 02:13:24 +0000 (10:13 +0800)
committerJakub Kicinski <kuba@kernel.org>
Sat, 12 Apr 2025 03:17:36 +0000 (20:17 -0700)
A dbg log is generated when the driver modifies the MTU,
which is expected to trace the change of the MTU.

However, the log is recorded after WRITE_ONCE().
At this time, netdev->mtu has been changed to the new value.
As a result, netdev->mtu is the same as new_mtu.

This patch modifies the log location and records logs before WRITE_ONCE().

Fixes: ff4edac6e9bd ("net: hibmcge: Implement some .ndo functions")
Signed-off-by: Jijie Shao <shaojijie@huawei.com>
Reviewed-by: Simon Horman <horms@kernel.org>
Link: https://patch.msgid.link/20250410021327.590362-5-shaojijie@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/hisilicon/hibmcge/hbg_main.c

index e5c961ad4b9b80000f5d3e44223f39d368712b7b..2e64dc1ab355e321106a55e3f81d5dde69508e32 100644 (file)
@@ -203,12 +203,12 @@ static int hbg_net_change_mtu(struct net_device *netdev, int new_mtu)
        if (netif_running(netdev))
                return -EBUSY;
 
-       hbg_hw_set_mtu(priv, new_mtu);
-       WRITE_ONCE(netdev->mtu, new_mtu);
-
        dev_dbg(&priv->pdev->dev,
                "change mtu from %u to %u\n", netdev->mtu, new_mtu);
 
+       hbg_hw_set_mtu(priv, new_mtu);
+       WRITE_ONCE(netdev->mtu, new_mtu);
+
        return 0;
 }