]> www.infradead.org Git - users/willy/linux.git/commitdiff
staging: gpib: hp_82335: Return error value from gpib_register_driver()
authorNihar Chaithanya <niharchaithanya@gmail.com>
Mon, 30 Dec 2024 18:56:29 +0000 (00:26 +0530)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 7 Jan 2025 14:38:55 +0000 (15:38 +0100)
The function gpib_register_driver() can fail and does not return an
error value if it fails.

Return the error value if gpib_register_driver() fails. Add pr_err()
statement indicating the fail and also the error value.

Signed-off-by: Nihar Chaithanya <niharchaithanya@gmail.com>
Link: https://lore.kernel.org/r/20241230185633.175690-10-niharchaithanya@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/gpib/hp_82335/hp82335.c

index 40afe42aea4788ad9683e71cc9205a42b7f0abb9..45157ad65d530a5dd4bdb21c6ab071b8574be509 100644 (file)
@@ -325,7 +325,13 @@ void hp82335_detach(gpib_board_t *board)
 
 static int __init hp82335_init_module(void)
 {
-       gpib_register_driver(&hp82335_interface, THIS_MODULE);
+       int result = gpib_register_driver(&hp82335_interface, THIS_MODULE);
+
+       if (result) {
+               pr_err("hp82335: gpib_register_driver failed: error = %d\n", result);
+               return result;
+       }
+
        return 0;
 }