]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
net: phy: fix yt8521 duplicated argument to & or |
authorFrank <Frank.Sae@motor-comm.com>
Fri, 4 Nov 2022 08:44:41 +0000 (16:44 +0800)
committerDavid S. Miller <davem@davemloft.net>
Mon, 7 Nov 2022 11:33:22 +0000 (11:33 +0000)
cocci warnings: (new ones prefixed by >>)
>> drivers/net/phy/motorcomm.c:1122:8-35: duplicated argument to & or |
  drivers/net/phy/motorcomm.c:1126:8-35: duplicated argument to & or |
  drivers/net/phy/motorcomm.c:1130:8-34: duplicated argument to & or |
  drivers/net/phy/motorcomm.c:1134:8-34: duplicated argument to & or |

 The second YT8521_RC1R_GE_TX_DELAY_xx should be YT8521_RC1R_FE_TX_DELAY_xx.

Fixes: 70479a40954c ("net: phy: Add driver for Motorcomm yt8521 gigabit ethernet phy")
Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Signed-off-by: Frank <Frank.Sae@motor-comm.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/motorcomm.c

index c7593f224177f6acce6386249ec1e807ffc54bc8..bd1ab5d0631f1fa99ec0646554864665a105e7d2 100644 (file)
@@ -1119,19 +1119,19 @@ static int yt8521_config_init(struct phy_device *phydev)
 
        switch (phydev->interface) {
        case PHY_INTERFACE_MODE_RGMII:
-               val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS;
+               val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS;
                val |= YT8521_RC1R_RX_DELAY_DIS;
                break;
        case PHY_INTERFACE_MODE_RGMII_RXID:
-               val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_GE_TX_DELAY_DIS;
+               val = YT8521_RC1R_GE_TX_DELAY_DIS | YT8521_RC1R_FE_TX_DELAY_DIS;
                val |= YT8521_RC1R_RX_DELAY_EN;
                break;
        case PHY_INTERFACE_MODE_RGMII_TXID:
-               val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN;
+               val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN;
                val |= YT8521_RC1R_RX_DELAY_DIS;
                break;
        case PHY_INTERFACE_MODE_RGMII_ID:
-               val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_GE_TX_DELAY_EN;
+               val = YT8521_RC1R_GE_TX_DELAY_EN | YT8521_RC1R_FE_TX_DELAY_EN;
                val |= YT8521_RC1R_RX_DELAY_EN;
                break;
        case PHY_INTERFACE_MODE_SGMII: