]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
phonet: refcount leak in pep_sock_accep
authorHangyu Hua <hbh25y@gmail.com>
Thu, 9 Dec 2021 08:28:39 +0000 (16:28 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 11 Jan 2022 12:58:50 +0000 (13:58 +0100)
commit bcd0f93353326954817a4f9fa55ec57fb38acbb0 upstream.

sock_hold(sk) is invoked in pep_sock_accept(), but __sock_put(sk) is not
invoked in subsequent failure branches(pep_accept_conn() != 0).

Signed-off-by: Hangyu Hua <hbh25y@gmail.com>
Link: https://lore.kernel.org/r/20211209082839.33985-1-hbh25y@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Aayush Agarwal <aayush.a.agarwal@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/phonet/pep.c

index c0b4cc1e108b3b1921bbfd78e87d66ff95186ae8..fe01cc788448a9ee783206e75d25b37b3b125bd3 100644 (file)
@@ -881,6 +881,7 @@ static struct sock *pep_sock_accept(struct sock *sk, int flags, int *errp,
 
        err = pep_accept_conn(newsk, skb);
        if (err) {
+               __sock_put(sk);
                sock_put(newsk);
                newsk = NULL;
                goto drop;