]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
drm/amd/display: Remove always true condition
authorAlex Hung <alex.hung@amd.com>
Sat, 15 Jun 2024 01:10:40 +0000 (19:10 -0600)
committerAlex Deucher <alexander.deucher@amd.com>
Thu, 27 Jun 2024 21:10:38 +0000 (17:10 -0400)
[WHAT & HOW]
advanced_pstate_switching was initialized to false and never assigned to
another value; as a result !advanced_pstate_switching is always true and
should be removed.

This fixes 2 DEADCODE issues reported by Coverity.

Reviewed-by: Rodrigo Siqueira <rodrigo.siqueira@amd.com>
Signed-off-by: Alex Hung <alex.hung@amd.com>
Tested-by: Daniel Wheeler <daniel.wheeler@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/dml2/dml2_wrapper.c

index 90bb6e7183015af6fa6f32b66c751bcbdd27b228..60e2bf4ae6dea94e0d947ee3f20afe26b8447488 100644 (file)
@@ -442,7 +442,6 @@ static bool optimize_pstate_with_svp_and_drr(struct dml2_context *dml2, struct d
        bool result = false;
        int drr_display_index = 0, non_svp_streams = 0;
        bool force_svp = dml2->config.svp_pstate.force_enable_subvp;
-       bool advanced_pstate_switching = false;
 
        display_state->bw_ctx.bw.dcn.clk.fw_based_mclk_switching = false;
        display_state->bw_ctx.bw.dcn.legacy_svp_drr_stream_index_valid = false;
@@ -451,8 +450,7 @@ static bool optimize_pstate_with_svp_and_drr(struct dml2_context *dml2, struct d
 
        if (!result) {
                pstate_optimization_done = true;
-       } else if (!advanced_pstate_switching ||
-               (s->mode_support_info.DRAMClockChangeSupport[0] != dml_dram_clock_change_unsupported && !force_svp)) {
+       } else if (s->mode_support_info.DRAMClockChangeSupport[0] != dml_dram_clock_change_unsupported && !force_svp) {
                pstate_optimization_success = true;
                pstate_optimization_done = true;
        }