]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
thermal: qcom-spmi-adc-tm5: Simplify with scoped for each OF child loop
authorKrzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Thu, 10 Oct 2024 18:06:20 +0000 (20:06 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Tue, 26 Nov 2024 12:28:43 +0000 (13:28 +0100)
Use scoped for_each_available_child_of_node_scoped() when iterating over
device nodes to make code a bit simpler.

Reviewed-by: Chen-Yu Tsai <wenst@chromium.org>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Link: https://patch.msgid.link/20241010-b4-cleanup-h-of-node-put-thermal-v4-4-bfbe29ad81f4@linaro.org
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/thermal/qcom/qcom-spmi-adc-tm5.c

index 5e94a45eba3eef65e436a01b3aa58aabf5f706c2..d7f2e6ca92c2c9fb532ca5d4bcc22b6c2cddbdb0 100644 (file)
@@ -938,7 +938,6 @@ static const struct adc_tm5_data adc_tm5_gen2_data_pmic = {
 static int adc_tm5_get_dt_data(struct adc_tm5_chip *adc_tm, struct device_node *node)
 {
        struct adc_tm5_channel *channels;
-       struct device_node *child;
        u32 value;
        int ret;
        struct device *dev = adc_tm->dev;
@@ -982,12 +981,10 @@ static int adc_tm5_get_dt_data(struct adc_tm5_chip *adc_tm, struct device_node *
                adc_tm->avg_samples = VADC_DEF_AVG_SAMPLES;
        }
 
-       for_each_available_child_of_node(node, child) {
+       for_each_available_child_of_node_scoped(node, child) {
                ret = adc_tm5_get_dt_channel_data(adc_tm, channels, child);
-               if (ret) {
-                       of_node_put(child);
+               if (ret)
                        return ret;
-               }
 
                channels++;
        }