]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ASoC: amd: amd_sdw: Fix unlikely uninitialized variable use in create_sdw_dailinks()
authorVijendar Mukunda <Vijendar.Mukunda@amd.com>
Tue, 6 May 2025 12:07:22 +0000 (17:37 +0530)
committerMark Brown <broonie@kernel.org>
Tue, 6 May 2025 13:48:24 +0000 (22:48 +0900)
Initialize current_be_id to 0 in AMD legacy stack(NO DSP enabled) SoundWire
generic machine driver code to handle the unlikely case when there are no
devices connected to a DAI.

In this case create_sdw_dailink() would return without touching the passed
pointer to current_be_id.

Found by gcc -fanalyzer

Cc: stable@vger.kernel.org
Fixes: 2981d9b0789c4 ("ASoC: amd: acp: add soundwire machine driver for legacy stack")
Signed-off-by: Vijendar Mukunda <Vijendar.Mukunda@amd.com>
Link: https://patch.msgid.link/20250506120823.3621604-1-Vijendar.Mukunda@amd.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/amd/acp/acp-sdw-legacy-mach.c

index 2020c5cfb3d5d773349f5c0c4ca847c6cfe7202f..582c68aee6e589c3d740bc79e1edbdd5549823ae 100644 (file)
@@ -272,7 +272,7 @@ static int create_sdw_dailinks(struct snd_soc_card *card,
 
        /* generate DAI links by each sdw link */
        while (soc_dais->initialised) {
-               int current_be_id;
+               int current_be_id = 0;
 
                ret = create_sdw_dailink(card, soc_dais, dai_links,
                                         &current_be_id, codec_conf, sdw_platform_component);