LEDS: memory leak in blinkm_led_common_set()

This can return without freeing the bl_work struct.  Also there was no
check for allocation failure.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Jan-Simon Möller <jansimon.moeller@gmx.de>
Signed-off-by: Bryan Wu <bryan.wu@canonical.com>

diff --git a/drivers/leds/leds-blinkm.c b/drivers/leds/leds-blinkm.c
index 5a9df43e5302076a8bbee57dc8d9b4f112f55a89..ae6ad6331f238d6507db9058756901919f487f36 100644 (file)
--- a/drivers/leds/leds-blinkm.c
+++ b/drivers/leds/leds-blinkm.c
@@ -468,8 +468,7 @@ static int blinkm_led_common_set(struct led_classdev *led_cdev,
        /* led_brightness is 0, 127 or 255 - we just use it here as-is */
        struct blinkm_led *led = cdev_to_blmled(led_cdev);
        struct blinkm_data *data = i2c_get_clientdata(led->i2c_client);
-       struct blinkm_work *bl_work = kzalloc(sizeof(struct blinkm_work),
-                                             GFP_ATOMIC);
+       struct blinkm_work *bl_work;
 
        switch (color) {
        case RED:
@@ -511,6 +510,10 @@ static int blinkm_led_common_set(struct led_classdev *led_cdev,
                return -EINVAL;
        }
 
+       bl_work = kzalloc(sizeof(*bl_work), GFP_ATOMIC);
+       if (!bl_work)
+               return -ENOMEM;
+
        atomic_inc(&led->active);
        dev_dbg(&led->i2c_client->dev,
                        "#TO_SCHED# next_red = %d, next_green = %d,"