]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
drivers/perf: hisi_pcie: Introduce hisi_pcie_pmu_get_event_ctrl_val()
authorYicong Yang <yangyicong@hisilicon.com>
Fri, 23 Feb 2024 10:33:53 +0000 (18:33 +0800)
committerWill Deacon <will@kernel.org>
Mon, 4 Mar 2024 14:18:28 +0000 (14:18 +0000)
Factor out retrieving of the register value for the
corresponding event from hisi_pcie_config_event_ctrl() into a
new function hisi_pcie_pmu_get_event_ctrl_val() allowing future
reuse.

Signed-off-by: Yicong Yang <yangyicong@hisilicon.com>
Reviewed-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
Link: https://lore.kernel.org/r/20240223103359.18669-3-yangyicong@huawei.com
Signed-off-by: Will Deacon <will@kernel.org>
drivers/perf/hisilicon/hisi_pcie_pmu.c

index 9760ddde46fd4662cda479602dc80e7d3aede153..2468cf3b007c3765d6b8fc74e7b98efebc7006cb 100644 (file)
@@ -216,10 +216,8 @@ static void hisi_pcie_pmu_writeq(struct hisi_pcie_pmu *pcie_pmu, u32 reg_offset,
        writeq_relaxed(val, pcie_pmu->base + offset);
 }
 
-static void hisi_pcie_pmu_config_event_ctrl(struct perf_event *event)
+static u64 hisi_pcie_pmu_get_event_ctrl_val(struct perf_event *event)
 {
-       struct hisi_pcie_pmu *pcie_pmu = to_pcie_pmu(event->pmu);
-       struct hw_perf_event *hwc = &event->hw;
        u64 port, trig_len, thr_len, len_mode;
        u64 reg = HISI_PCIE_INIT_SET;
 
@@ -256,6 +254,15 @@ static void hisi_pcie_pmu_config_event_ctrl(struct perf_event *event)
        else
                reg |= FIELD_PREP(HISI_PCIE_LEN_M, HISI_PCIE_LEN_M_DEFAULT);
 
+       return reg;
+}
+
+static void hisi_pcie_pmu_config_event_ctrl(struct perf_event *event)
+{
+       struct hisi_pcie_pmu *pcie_pmu = to_pcie_pmu(event->pmu);
+       struct hw_perf_event *hwc = &event->hw;
+       u64 reg = hisi_pcie_pmu_get_event_ctrl_val(event);
+
        hisi_pcie_pmu_writeq(pcie_pmu, HISI_PCIE_EVENT_CTRL, hwc->idx, reg);
 }