]> www.infradead.org Git - users/hch/misc.git/commitdiff
r8169: log that system vendor flags ASPM as safe
authorHeiner Kallweit <hkallweit1@gmail.com>
Fri, 12 Sep 2025 19:11:23 +0000 (21:11 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 16 Sep 2025 01:16:26 +0000 (18:16 -0700)
ASPM isn't disabled if system vendor flags it as safe. Log this,
in order to know whom to blame if a user complains about ASPM
issues on such a system.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Link: https://patch.msgid.link/a532b46b-ef68-4d68-a129-35ff0ee35150@gmail.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
drivers/net/ethernet/realtek/r8169_main.c

index 9c601f271c02b903b22544519c747d0c65f366da..75272510f7e26dde0fd24681c2bb3def661b6da4 100644 (file)
@@ -5441,10 +5441,12 @@ static int rtl_init_one(struct pci_dev *pdev, const struct pci_device_id *ent)
        /* Disable ASPM L1 as that cause random device stop working
         * problems as well as full system hangs for some PCIe devices users.
         */
-       if (rtl_aspm_is_safe(tp))
+       if (rtl_aspm_is_safe(tp)) {
+               dev_info(&pdev->dev, "System vendor flags ASPM as safe\n");
                rc = 0;
-       else
+       } else {
                rc = pci_disable_link_state(pdev, PCIE_LINK_STATE_L1);
+       }
        tp->aspm_manageable = !rc;
 
        tp->dash_type = rtl_get_dash_type(tp);