]> www.infradead.org Git - users/hch/dma-mapping.git/commitdiff
serial: qcom-geni: drop unused receive parameter
authorJohan Hovold <johan+linaro@kernel.org>
Wed, 9 Oct 2024 14:51:09 +0000 (16:51 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 11 Oct 2024 06:39:23 +0000 (08:39 +0200)
Serial drivers should not be dropping characters themselves, but at
least drop the unused 'drop' parameter from the receive handler for now.

Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Johan Hovold <johan+linaro@kernel.org>
Link: https://lore.kernel.org/r/20241009145110.16847-9-johan+linaro@kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/tty/serial/qcom_geni_serial.c

index 22e468065666304cee4c970fbffb17591f1936af..9dd304cdcd86ffa5296ce7967791a7952165fe30 100644 (file)
@@ -580,7 +580,7 @@ static void handle_rx_console(struct uart_port *uport, u32 bytes, bool drop)
 }
 #endif /* CONFIG_SERIAL_QCOM_GENI_CONSOLE */
 
-static void handle_rx_uart(struct uart_port *uport, u32 bytes, bool drop)
+static void handle_rx_uart(struct uart_port *uport, u32 bytes)
 {
        struct qcom_geni_serial_port *port = to_dev_port(uport);
        struct tty_port *tport = &uport->state->port;
@@ -873,7 +873,7 @@ static void qcom_geni_serial_handle_rx_dma(struct uart_port *uport, bool drop)
        }
 
        if (!drop)
-               handle_rx_uart(uport, rx_in, drop);
+               handle_rx_uart(uport, rx_in);
 
        ret = geni_se_rx_dma_prep(&port->se, port->rx_buf,
                                  DMA_RX_BUF_SIZE,