mt76: mt7915: fix potential memory leak in mcu message handler

Fix potential memory leak in mcu message handler on error condition.

Fixes: c6b002bcdfa6 ("mt76: add mac80211 driver for MT7915 PCIe-based chipsets")
Signed-off-by: Ryder Lee <ryder.lee@mediatek.com>
Signed-off-by: Felix Fietkau <nbd@nbd.name>

diff --git a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
index 93b1439e147b0f6c053f5f81f1d86dc15625daa4..eaed5ef054016e5af4246eb1dfc900addc5ec715 100644 (file)
--- a/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
+++ b/drivers/net/wireless/mediatek/mt76/mt7915/mcu.c
@@ -312,8 +312,10 @@ mt7915_mcu_parse_response(struct mt7915_dev *dev, int cmd,
        struct mt7915_mcu_rxd *rxd = (struct mt7915_mcu_rxd *)skb->data;
        int ret = 0;
 
-       if (seq != rxd->seq)
-               return -EAGAIN;
+       if (seq != rxd->seq) {
+               ret = -EAGAIN;
+               goto out;
+       }
 
        switch (cmd) {
        case -MCU_CMD_PATCH_SEM_CONTROL:
@@ -330,6 +332,7 @@ mt7915_mcu_parse_response(struct mt7915_dev *dev, int cmd,
        default:
                break;
        }
+out:
        dev_kfree_skb(skb);
 
        return ret;