USB: serial: kobil_sct: restore initial terminal settings

Commit 6a6c8b362be3 ("usb, kobil: Sort out some bogus tty handling")
intended to fix and clean up the device-specific initial terminal
settings but instead confused the termios input and local control flags
and re-enabled ICRNL and IXON.

Drop the bogus masking of l-flags from the default i-flags (which has no
effect) and restore the original device-specific i-flags.

Fixes: 6a6c8b362be3 ("usb, kobil: Sort out some bogus tty handling")
Signed-off-by: Johan Hovold <johan@kernel.org>

diff --git a/drivers/usb/serial/kobil_sct.c b/drivers/usb/serial/kobil_sct.c
index 5eb59ac3e56411cfa3f4ed729070c3ab481dc069..464433be2034437876fdb3567275eed0e481728c 100644 (file)
--- a/drivers/usb/serial/kobil_sct.c
+++ b/drivers/usb/serial/kobil_sct.c
@@ -155,8 +155,7 @@ static void kobil_init_termios(struct tty_struct *tty)
 {
        /* Default to echo off and other sane device settings */
        tty->termios.c_lflag = 0;
-       tty->termios.c_iflag &= ~(ISIG | ICANON | ECHO | IEXTEN | XCASE);
-       tty->termios.c_iflag |= IGNBRK | IGNPAR | IXOFF;
+       tty->termios.c_iflag = IGNBRK | IGNPAR | IXOFF;
        /* do NOT translate CR to CR-NL (0x0A -> 0x0A 0x0D) */
        tty->termios.c_oflag &= ~ONLCR;
 }