]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
btrfs: remove pointless iocb::ki_pos addition in btrfs_encoded_read()
authorMark Harmstone <maharmstone@fb.com>
Tue, 22 Oct 2024 14:50:16 +0000 (15:50 +0100)
committerDavid Sterba <dsterba@suse.com>
Mon, 11 Nov 2024 13:34:21 +0000 (14:34 +0100)
iocb->ki_pos isn't used after this function, so there's no point in
changing its value.

Signed-off-by: Mark Harmstone <maharmstone@fb.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/inode.c

index 87a30d9cb6e57996ff38b5f18cc3d1f718a48dc5..dd2e4d57af214bfe9b4c80a4c0e2431d63d7ebb6 100644 (file)
@@ -9251,7 +9251,7 @@ ssize_t btrfs_encoded_read(struct kiocb *iocb, struct iov_iter *iter,
                ret = btrfs_encoded_read_inline(iocb, iter, start, lockend,
                                                &cached_state, extent_start,
                                                count, encoded, &unlocked);
-               goto out;
+               goto out_em;
        }
 
        /*
@@ -9317,9 +9317,6 @@ ssize_t btrfs_encoded_read(struct kiocb *iocb, struct iov_iter *iter,
                                                 &unlocked);
        }
 
-out:
-       if (ret >= 0)
-               iocb->ki_pos += encoded->len;
 out_em:
        free_extent_map(em);
 out_unlock_extent: