HID: picoLCD: Deletion of unnecessary checks before three function calls

The functions backlight_device_unregister(), lcd_device_unregister() and
rc_unregister_device() test whether their argument is NULL and then
return immediately. Thus the test around the call is not needed.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Reviewed-by: Bruno Prémont <bonbons@linux-vserver.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>

diff --git a/drivers/hid/hid-picolcd_backlight.c b/drivers/hid/hid-picolcd_backlight.c
index a32c5f86b0b3f667466b921f1ed4581ad1857b1e..808807ad388f9c9c6048cbd30c7969e8cd1937e2 100644 (file)
--- a/drivers/hid/hid-picolcd_backlight.c
+++ b/drivers/hid/hid-picolcd_backlight.c
@@ -94,8 +94,7 @@ void picolcd_exit_backlight(struct picolcd_data *data)
        struct backlight_device *bdev = data->backlight;
 
        data->backlight = NULL;
-       if (bdev)
-               backlight_device_unregister(bdev);
+       backlight_device_unregister(bdev);
 }
 
 int picolcd_resume_backlight(struct picolcd_data *data)

diff --git a/drivers/hid/hid-picolcd_cir.c b/drivers/hid/hid-picolcd_cir.c
index 045f8ebf16b53747746bf92c110f434ffdaff319..96286510f42e990eef1a0fd6a03abfd57fd42f57 100644 (file)
--- a/drivers/hid/hid-picolcd_cir.c
+++ b/drivers/hid/hid-picolcd_cir.c
@@ -145,7 +145,6 @@ void picolcd_exit_cir(struct picolcd_data *data)
        struct rc_dev *rdev = data->rc_dev;
 
        data->rc_dev = NULL;
-       if (rdev)
-               rc_unregister_device(rdev);
+       rc_unregister_device(rdev);
 }
 

diff --git a/drivers/hid/hid-picolcd_lcd.c b/drivers/hid/hid-picolcd_lcd.c
index 89821c2da6d76b766347ae629314d68df3033942..22dcbe13da892cc3ede9f9cdccf280d752035d92 100644 (file)
--- a/drivers/hid/hid-picolcd_lcd.c
+++ b/drivers/hid/hid-picolcd_lcd.c
@@ -92,8 +92,7 @@ void picolcd_exit_lcd(struct picolcd_data *data)
        struct lcd_device *ldev = data->lcd;
 
        data->lcd = NULL;
-       if (ldev)
-               lcd_device_unregister(ldev);
+       lcd_device_unregister(ldev);
 }
 
 int picolcd_resume_lcd(struct picolcd_data *data)