ALSA: firewire: fireface: Use safer strscpy() instead of strcpy()

Use a safer function strscpy() instead of strcpy() for copying to
arrays.

Only idiomatic code replacement, and no functional changes.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Reviewed-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
Link: https://patch.msgid.link/20250710100727.22653-17-tiwai@suse.de

diff --git a/sound/firewire/fireface/ff-hwdep.c b/sound/firewire/fireface/ff-hwdep.c
index 8a741b3b0436f3aa0ebb84e231ec186cdefa198f..ca5c5dee71f289a315786a414e44e3c967066e81 100644 (file)
--- a/sound/firewire/fireface/ff-hwdep.c
+++ b/sound/firewire/fireface/ff-hwdep.c
@@ -197,7 +197,7 @@ int snd_ff_create_hwdep_devices(struct snd_ff *ff)
        if (err < 0)
                return err;
 
-       strcpy(hwdep->name, ff->card->driver);
+       strscpy(hwdep->name, ff->card->driver);
        hwdep->iface = SNDRV_HWDEP_IFACE_FW_FIREFACE;
        hwdep->ops = hwdep_ops;
        hwdep->private_data = ff;

diff --git a/sound/firewire/fireface/ff.c b/sound/firewire/fireface/ff.c
index 6e84e4787259e7f13040a580305fa0354c601c7a..5d2c4fbf44341a16bb8ea0d3638a3f7586af8780 100644 (file)
--- a/sound/firewire/fireface/ff.c
+++ b/sound/firewire/fireface/ff.c
@@ -27,9 +27,9 @@ static void name_card(struct snd_ff *ff)
 
        name = names[ff->unit_version];
 
-       strcpy(ff->card->driver, "Fireface");
-       strcpy(ff->card->shortname, name);
-       strcpy(ff->card->mixername, name);
+       strscpy(ff->card->driver, "Fireface");
+       strscpy(ff->card->shortname, name);
+       strscpy(ff->card->mixername, name);
        snprintf(ff->card->longname, sizeof(ff->card->longname),
                 "RME %s, GUID %08x%08x at %s, S%d", name,
                 fw_dev->config_rom[3], fw_dev->config_rom[4],