]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
scsi: qedf: Remove always false 'tmp_prio < 0' statement
authorAustin Kim <austindh.kim@gmail.com>
Thu, 19 Sep 2019 07:55:48 +0000 (16:55 +0900)
committerMartin K. Petersen <martin.petersen@oracle.com>
Tue, 24 Sep 2019 03:09:42 +0000 (23:09 -0400)
Since tmp_prio is declared as u8, the following statement is always false.
   tmp_prio < 0

So remove 'always false' statement.

Link: https://lore.kernel.org/r/20190919075548.GA112801@LGEARND20B15
Signed-off-by: Austin Kim <austindh.kim@gmail.com>
Acked-by: Saurav Kashyap <skashyap@marvell.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qedf/qedf_main.c

index 9c24f3834d70a9fdf9af5f1772c7588f90b991b7..1d2c111bdf822e05f103eabe078f94e22ada5e8b 100644 (file)
@@ -596,7 +596,7 @@ static void qedf_dcbx_handler(void *dev, struct qed_dcbx_get *get, u32 mib_type)
                tmp_prio = get->operational.app_prio.fcoe;
                if (qedf_default_prio > -1)
                        qedf->prio = qedf_default_prio;
-               else if (tmp_prio < 0 || tmp_prio > 7) {
+               else if (tmp_prio > 7) {
                        QEDF_INFO(&(qedf->dbg_ctx), QEDF_LOG_DISC,
                            "FIP/FCoE prio %d out of range, setting to %d.\n",
                            tmp_prio, QEDF_DEFAULT_PRIO);