i3c: mipi-i3c-hci: Add DMA bounce buffer for private transfers

Implement a local bounce buffer for private I3C SDR and I2C transfers
when using DMA and the buffer attached to the transfer is not DMA safe.

Otherwise the DMA transfer will fail and with following warning:

[   11.411059] i3c mipi-i3c-hci.0: rejecting DMA map of vmalloc memory
[   11.417313] WARNING: CPU: 3 PID: 357 at include/linux/dma-mapping.h:332 hci_dma_queue_xfer+0x2e2/0x300 [mipi_i3c_hci]

Strictly speaking private I3C SDR transfers are expected to pass a
DMA-able buffer. However I fear this requirement may easily be slipped
or go unnoticed when I3C interface support is added into a existing
device driver that use regmap API to read/write stack variables.

For example this is the case with the commit 2660b0080bb2 ("iio: imu:
st_lsm6dsx: add i3c basic support for LSM6DSO and LSM6DSR").

Buffer of an I2C message is not required to be DMA safe and the I2C core
provides i2c_(get|put)_dma_safe_msg_buf() helpers for the host
controllers that do DMA and that is also recommendation for the
i2c_xfers() callback from the I3C core.

However due to above I3C private transfers reason I decided to implement
a bounce buffer for them and reuse the same code for the I2C transfers
too. Since this driver is currently the only I3C host controller driver
that can do DMA the implementation is done here and not in I3C core.

Signed-off-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>
Link: https://lore.kernel.org/r/20231109133708.653950-5-jarkko.nikula@linux.intel.com
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

diff --git a/drivers/i3c/master/mipi-i3c-hci/core.c b/drivers/i3c/master/mipi-i3c-hci/core.c
index 8471a1fe1dad98e2f84287d337dcad4c9de18eb3..d7e966a255833730c40728725e5f6c3817083cd9 100644 (file)
--- a/drivers/i3c/master/mipi-i3c-hci/core.c
+++ b/drivers/i3c/master/mipi-i3c-hci/core.c
@@ -276,6 +276,34 @@ static int i3c_hci_daa(struct i3c_master_controller *m)
        return hci->cmd->perform_daa(hci);
 }
 
+static int i3c_hci_alloc_safe_xfer_buf(struct i3c_hci *hci,
+                                      struct hci_xfer *xfer)
+{
+       if (hci->io != &mipi_i3c_hci_dma ||
+           xfer->data == NULL || !is_vmalloc_addr(xfer->data))
+               return 0;
+
+       if (xfer->rnw)
+               xfer->bounce_buf = kzalloc(xfer->data_len, GFP_KERNEL);
+       else
+               xfer->bounce_buf = kmemdup(xfer->data,
+                                          xfer->data_len, GFP_KERNEL);
+
+       return xfer->bounce_buf == NULL ? -ENOMEM : 0;
+}
+
+static void i3c_hci_free_safe_xfer_buf(struct i3c_hci *hci,
+                                      struct hci_xfer *xfer)
+{
+       if (hci->io != &mipi_i3c_hci_dma || xfer->bounce_buf == NULL)
+               return;
+
+       if (xfer->rnw)
+               memcpy(xfer->data, xfer->bounce_buf, xfer->data_len);
+
+       kfree(xfer->bounce_buf);
+}
+
 static int i3c_hci_priv_xfers(struct i3c_dev_desc *dev,
                              struct i3c_priv_xfer *i3c_xfers,
                              int nxfers)
@@ -309,6 +337,9 @@ static int i3c_hci_priv_xfers(struct i3c_dev_desc *dev,
                }
                hci->cmd->prep_i3c_xfer(hci, dev, &xfer[i]);
                xfer[i].cmd_desc[0] |= CMD_0_ROC;
+               ret = i3c_hci_alloc_safe_xfer_buf(hci, &xfer[i]);
+               if (ret)
+                       goto out;
        }
        last = i - 1;
        xfer[last].cmd_desc[0] |= CMD_0_TOC;
@@ -332,6 +363,9 @@ static int i3c_hci_priv_xfers(struct i3c_dev_desc *dev,
        }
 
 out:
+       for (i = 0; i < nxfers; i++)
+               i3c_hci_free_safe_xfer_buf(hci, &xfer[i]);
+
        hci_free_xfer(xfer, nxfers);
        return ret;
 }
@@ -357,6 +391,9 @@ static int i3c_hci_i2c_xfers(struct i2c_dev_desc *dev,
                xfer[i].rnw = i2c_xfers[i].flags & I2C_M_RD;
                hci->cmd->prep_i2c_xfer(hci, dev, &xfer[i]);
                xfer[i].cmd_desc[0] |= CMD_0_ROC;
+               ret = i3c_hci_alloc_safe_xfer_buf(hci, &xfer[i]);
+               if (ret)
+                       goto out;
        }
        last = i - 1;
        xfer[last].cmd_desc[0] |= CMD_0_TOC;
@@ -378,6 +415,9 @@ static int i3c_hci_i2c_xfers(struct i2c_dev_desc *dev,
        }
 
 out:
+       for (i = 0; i < nxfers; i++)
+               i3c_hci_free_safe_xfer_buf(hci, &xfer[i]);
+
        hci_free_xfer(xfer, nxfers);
        return ret;
 }

diff --git a/drivers/i3c/master/mipi-i3c-hci/dma.c b/drivers/i3c/master/mipi-i3c-hci/dma.c
index c805a8497319dbb76f51a97e107ab9206e2a3515..4e01a95cc4d0ad2485caf13fa6776374ce6d0e91 100644 (file)
--- a/drivers/i3c/master/mipi-i3c-hci/dma.c
+++ b/drivers/i3c/master/mipi-i3c-hci/dma.c
@@ -362,6 +362,7 @@ static int hci_dma_queue_xfer(struct i3c_hci *hci,
        struct hci_rh_data *rh;
        unsigned int i, ring, enqueue_ptr;
        u32 op1_val, op2_val;
+       void *buf;
 
        /* For now we only use ring 0 */
        ring = 0;
@@ -390,9 +391,10 @@ static int hci_dma_queue_xfer(struct i3c_hci *hci,
 
                /* 2nd and 3rd words of Data Buffer Descriptor Structure */
                if (xfer->data) {
+                       buf = xfer->bounce_buf ? xfer->bounce_buf : xfer->data;
                        xfer->data_dma =
                                dma_map_single(&hci->master.dev,
-                                              xfer->data,
+                                              buf,
                                               xfer->data_len,
                                               xfer->rnw ?
                                                  DMA_FROM_DEVICE :

diff --git a/drivers/i3c/master/mipi-i3c-hci/hci.h b/drivers/i3c/master/mipi-i3c-hci/hci.h
index f109923f6c3f3e88139288e2bdfd9aafe798d54b..f94d95e024becc41106166073fd62edee55d032e 100644 (file)
--- a/drivers/i3c/master/mipi-i3c-hci/hci.h
+++ b/drivers/i3c/master/mipi-i3c-hci/hci.h
@@ -90,6 +90,7 @@ struct hci_xfer {
                struct {
                        /* DMA specific */
                        dma_addr_t data_dma;
+                       void *bounce_buf;
                        int ring_number;
                        int ring_entry;
                };