]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
perf tests bp_account: Fix leaked file descriptor
authorLeo Yan <leo.yan@arm.com>
Fri, 11 Jul 2025 11:10:15 +0000 (12:10 +0100)
committerNamhyung Kim <namhyung@kernel.org>
Fri, 11 Jul 2025 19:05:02 +0000 (12:05 -0700)
Since the commit e9846f5ead26 ("perf test: In forked mode add check that
fds aren't leaked"), the test "Breakpoint accounting" reports the error:

  # perf test -vvv "Breakpoint accounting"
  20: Breakpoint accounting:
  --- start ---
  test child forked, pid 373
  failed opening event 0
  failed opening event 0
  watchpoints count 4, breakpoints count 6, has_ioctl 1, share 0
  wp 0 created
  wp 1 created
  wp 2 created
  wp 3 created
  wp 0 modified to bp
  wp max created
  ---- end(0) ----
  Leak of file descriptor 7 that opened: 'anon_inode:[perf_event]'

A watchpoint's file descriptor was not properly released. This patch
fixes the leak.

Fixes: 032db28e5fa3 ("perf tests: Add breakpoint accounting/modify test")
Reported-by: Aishwarya TCV <aishwarya.tcv@arm.com>
Signed-off-by: Leo Yan <leo.yan@arm.com>
Reviewed-by: Ian Rogers <irogers@google.com>
Link: https://lore.kernel.org/r/20250711-perf_fix_breakpoint_accounting-v1-1-b314393023f9@arm.com
Signed-off-by: Namhyung Kim <namhyung@kernel.org>
tools/perf/tests/bp_account.c

index 4cb7d486b5c178c622be4fc7e9c8c5a924df9d9b..047433c977bc9de4f8984268a2a9826d6bfa6f17 100644 (file)
@@ -104,6 +104,7 @@ static int bp_accounting(int wp_cnt, int share)
                fd_wp = wp_event((void *)&the_var, &attr_new);
                TEST_ASSERT_VAL("failed to create max wp\n", fd_wp != -1);
                pr_debug("wp max created\n");
+               close(fd_wp);
        }
 
        for (i = 0; i < wp_cnt; i++)