Fix sloppy cookie construction for Fortinet

Using the "default" cookie behavior of internal_split_cookies() should be a fallback, not the standard behavior.

Signed-off-by: Daniel Lenski <dlenski@gmail.com>

diff --git a/fortinet.c b/fortinet.c
index bbb86e190353b07035e800b6c31d240356d65c6d..5b1031702548193642cfa6ac68f520ebed005a65 100644 (file)
--- a/fortinet.c
+++ b/fortinet.c
@@ -199,8 +199,7 @@ int fortinet_obtain_cookie(struct openconnect_info *vpninfo)
                for (cookie = vpninfo->cookies; cookie; cookie = cookie->next) {
                        if (!strcmp(cookie->option, "SVPNCOOKIE")) {
                                free(vpninfo->cookie);
-                               vpninfo->cookie = strdup(cookie->value);
-                               if (!vpninfo->cookie)
+                               if (asprintf(&vpninfo->cookie, "SVPNCOOKIE=%s", cookie->value) < 0)
                                        goto nomem;
                                ret = 0;
                                goto out;