]> www.infradead.org Git - users/jedix/linux-maple.git/commitdiff
rcu: remove trace_rcu_kvfree_callback
authorVlastimil Babka <vbabka@suse.cz>
Thu, 23 Jan 2025 10:37:19 +0000 (11:37 +0100)
committerLiam R. Howlett <Liam.Howlett@oracle.com>
Mon, 3 Mar 2025 18:43:51 +0000 (13:43 -0500)
Tree RCU does not handle kvfree_rcu() by queueing individual objects by
call_rcu() anymore, thus the tracepoint and associated
__is_kvfree_rcu_offset() check is dead code now. Remove it.

Signed-off-by: Vlastimil Babka <vbabka@suse.cz>
include/trace/events/rcu.h
kernel/rcu/tree.c

index e81431deaa50b21725b08ad7c1a2992a0074065a..ac3b28b8939b78843aecb44bed8cb76c451ab060 100644 (file)
@@ -560,40 +560,6 @@ TRACE_EVENT_RCU(rcu_segcb_stats,
 
 );
 
-/*
- * Tracepoint for the registration of a single RCU callback of the special
- * kvfree() form.  The first argument is the RCU type, the second argument
- * is a pointer to the RCU callback, the third argument is the offset
- * of the callback within the enclosing RCU-protected data structure,
- * the fourth argument is the number of lazy callbacks queued, and the
- * fifth argument is the total number of callbacks queued.
- */
-TRACE_EVENT_RCU(rcu_kvfree_callback,
-
-       TP_PROTO(const char *rcuname, struct rcu_head *rhp, unsigned long offset,
-                long qlen),
-
-       TP_ARGS(rcuname, rhp, offset, qlen),
-
-       TP_STRUCT__entry(
-               __field(const char *, rcuname)
-               __field(void *, rhp)
-               __field(unsigned long, offset)
-               __field(long, qlen)
-       ),
-
-       TP_fast_assign(
-               __entry->rcuname = rcuname;
-               __entry->rhp = rhp;
-               __entry->offset = offset;
-               __entry->qlen = qlen;
-       ),
-
-       TP_printk("%s rhp=%p func=%ld %ld",
-                 __entry->rcuname, __entry->rhp, __entry->offset,
-                 __entry->qlen)
-);
-
 /*
  * Tracepoint for marking the beginning rcu_do_batch, performed to start
  * RCU callback invocation.  The first argument is the RCU flavor,
index 475f31deed1418d73d097bb4d39fe714814fefa3..5dbc4189037c501b8c671598131ed5ea6d4afd71 100644 (file)
@@ -2931,13 +2931,8 @@ static int __init rcu_spawn_core_kthreads(void)
 static void rcutree_enqueue(struct rcu_data *rdp, struct rcu_head *head, rcu_callback_t func)
 {
        rcu_segcblist_enqueue(&rdp->cblist, head);
-       if (__is_kvfree_rcu_offset((unsigned long)func))
-               trace_rcu_kvfree_callback(rcu_state.name, head,
-                                        (unsigned long)func,
-                                        rcu_segcblist_n_cbs(&rdp->cblist));
-       else
-               trace_rcu_callback(rcu_state.name, head,
-                                  rcu_segcblist_n_cbs(&rdp->cblist));
+       trace_rcu_callback(rcu_state.name, head,
+                          rcu_segcblist_n_cbs(&rdp->cblist));
        trace_rcu_segcb_stats(&rdp->cblist, TPS("SegCBQueued"));
 }