]> www.infradead.org Git - users/dwmw2/linux.git/commitdiff
ipv4: replace call_rcu by kfree_rcu for simple kmem_cache_free callback
authorJulia Lawall <Julia.Lawall@inria.fr>
Sun, 13 Oct 2024 20:16:49 +0000 (22:16 +0200)
committerJakub Kicinski <kuba@kernel.org>
Tue, 15 Oct 2024 17:50:21 +0000 (10:50 -0700)
Since SLOB was removed and since
commit 6c6c47b063b5 ("mm, slab: call kvfree_rcu_barrier() from kmem_cache_destroy()"),
it is not necessary to use call_rcu when the callback only performs
kmem_cache_free. Use kfree_rcu() directly.

The changes were made using Coccinelle.

Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Reviewed-by: Eric Dumazet <edumazet@google.com>
Acked-by: Paul E. McKenney <paulmck@kernel.org>
Acked-by: Vlastimil Babka <vbabka@suse.cz>
Link: https://patch.msgid.link/20241013201704.49576-3-Julia.Lawall@inria.fr
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/ipv4/fib_trie.c

index 09e31757e96c7472af2a9dfff7a731d4d076aa11..161f5526b86c6cf6a90f94cd296825a8301f0654 100644 (file)
@@ -292,15 +292,9 @@ static const int inflate_threshold = 50;
 static const int halve_threshold_root = 15;
 static const int inflate_threshold_root = 30;
 
-static void __alias_free_mem(struct rcu_head *head)
-{
-       struct fib_alias *fa = container_of(head, struct fib_alias, rcu);
-       kmem_cache_free(fn_alias_kmem, fa);
-}
-
 static inline void alias_free_mem_rcu(struct fib_alias *fa)
 {
-       call_rcu(&fa->rcu, __alias_free_mem);
+       kfree_rcu(fa, rcu);
 }
 
 #define TNODE_VMALLOC_MAX \